-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CUB uninitialized_copy #1913
Merged
Merged
+33
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CUB's uninitialized_copy is not related to std::uninitialized_copy since it only operates on a single value. Therefore, it should have a different name.
🟨 CI finished in 5h 45m: Pass: 99%/249 | Total: 4d 18h | Avg: 27m 38s | Max: 57m 49s | Hits: 54%/246735
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
Thrust | |
CUDA Experimental |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental |
🏃 Runner counts (total jobs: 249)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
40 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
elstehle
approved these changes
Jun 25, 2024
auto-merge was automatically disabled
June 25, 2024 08:48
Pull Request is not mergeable
🟩 CI finished in 11h 38m: Pass: 100%/249 | Total: 4d 19h | Avg: 27m 43s | Max: 57m 49s | Hits: 54%/248439
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
Thrust | |
CUDA Experimental |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental |
🏃 Runner counts (total jobs: 249)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
40 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
bernhardmgruber
added a commit
to bernhardmgruber/cccl
that referenced
this pull request
Jun 26, 2024
PR NVIDIA#1913 renamed cub::detail::uninitialized_copy to cub::detail::uninitialized_copy_single, but missed one instance.
bernhardmgruber
added a commit
that referenced
this pull request
Jun 26, 2024
PR #1913 renamed cub::detail::uninitialized_copy to cub::detail::uninitialized_copy_single, but missed one instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUB's
uninitialized_copy
is not related tostd::uninitialized_copy
since it only operates on a single value. Therefore, it should have a different name. This PR goes foruninitialized_copy_single
, but I am open to suggestions.