Symbol visibility is now invariant in regards to __cuda_std__ definition
#1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that steady_clock and system_clock have default visibility, dependent types such as sys_time also have default visibility as was requested by the usage of `_LIBCUDACXX_INLINE_VISIBILITY`.
🟨 CI Results [ Failed: 2 | Passed: 300 | Total: 302 ]
|
| # | Runner |
|---|---|
| 232 | linux-amd64-cpu16 |
| 28 | linux-amd64-gpu-v100-latest-1 |
| 24 | linux-arm64-cpu16 |
| 18 | windows-amd64-cpu16 |
👃 Inspect Changes
Modifications in project?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
miscco
added
libcu++
miscco
reviewed
Jun 10, 2024
robertmaynard
changed the title
__cuda_std__ definition
🟨 CI finished in 7h 58m: Pass: 96%/361 | Total: 6d 15h | Avg: 26m 32s | Max: 1h 04m | Hits: 24%/513574
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
🏃 Runner counts (total jobs: 361)
| # | Runner |
|---|---|
| 264 | linux-amd64-cpu16 |
| 52 | linux-amd64-gpu-v100-latest-1 |
| 24 | linux-arm64-cpu16 |
| 21 | windows-amd64-cpu16 |
🟨 CI finished in 7h 49m: Pass: 96%/361 | Total: 3d 00h | Avg: 12m 07s | Max: 1h 06m | Hits: 72%/513574
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
🏃 Runner counts (total jobs: 361)
| # | Runner |
|---|---|
| 264 | linux-amd64-cpu16 |
| 52 | linux-amd64-gpu-v100-latest-1 |
| 24 | linux-arm64-cpu16 |
| 21 | windows-amd64-cpu16 |
🟨 CI finished in 12h 58m: Pass: 99%/361 | Total: 7d 03h | Avg: 28m 26s | Max: 1h 12m | Hits: 38%/518700
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
🏃 Runner counts (total jobs: 361)
| # | Runner |
|---|---|
| 264 | linux-amd64-cpu16 |
| 52 | linux-amd64-gpu-v100-latest-1 |
| 24 | linux-arm64-cpu16 |
| 21 | windows-amd64-cpu16 |
🟩 CI finished in 18h 54m: Pass: 100%/361 | Total: 7d 04h | Avg: 28m 36s | Max: 1h 12m | Hits: 38%/521253
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
🏃 Runner counts (total jobs: 361)
| # | Runner |
|---|---|
| 264 | linux-amd64-cpu16 |
| 52 | linux-amd64-gpu-v100-latest-1 |
| 24 | linux-arm64-cpu16 |
| 21 | windows-amd64-cpu16 |
miscco
approved these changes
Jun 14, 2024
miscco
added a commit
to miscco/cccl
that referenced
this pull request
Jun 14, 2024
…ition (NVIDIA#1832) * Explicitly ensure all chrono types have default visibility Now that steady_clock and system_clock have default visibility, dependent types such as sys_time also have default visibility as was requested by the usage of `_LIBCUDACXX_INLINE_VISIBILITY`. * Do not override `_LIBCUDACXX_FUNC_VIS` and `_LIBCUDACXX_TYPE_VIS` * Do not define `_LIBCUDACXX_TYPE_VIS` for windows * Unconditionally define `_LIBCUDACXX_FUNC_VIS` * Just drop `_LIBCUDACXX_FUNC_VIS` * Do not mess with the docs * Fix formatting --------- Co-authored-by: Michael Schellenberger Costa <[email protected]>
wmaxey
added a commit
that referenced
this pull request
Jun 17, 2024
…ition (#1832) (#1864) * Explicitly ensure all chrono types have default visibility Now that steady_clock and system_clock have default visibility, dependent types such as sys_time also have default visibility as was requested by the usage of `_LIBCUDACXX_INLINE_VISIBILITY`. * Do not override `_LIBCUDACXX_FUNC_VIS` and `_LIBCUDACXX_TYPE_VIS` * Do not define `_LIBCUDACXX_TYPE_VIS` for windows * Unconditionally define `_LIBCUDACXX_FUNC_VIS` * Just drop `_LIBCUDACXX_FUNC_VIS` * Do not mess with the docs * Fix formatting --------- Co-authored-by: Robert Maynard <[email protected]> Co-authored-by: Wesley Maxey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the visibiltiy control changes when
__cuda_std__is defined. This allows for proper visibility exporting when-fvisibility=hiddenhas been passed.Now that steady_clock and system_clock have default visibility, dependent types such as sys_time also have default visibility as was requested by the usage of
_LIBCUDACXX_INLINE_VISIBILITY.Checklist