Clean up `merge_by_key` and `merge_key_value` tests #1824

bernhardmgruber · 2024-06-07T13:31:34Z

Spin-off from porting thrust::merge to CUB (#1817)

bernhardmgruber · 2024-06-10T13:06:20Z

thrust/testing/merge_by_key.cu

+  _CCCL_IF_CONSTEXPR (::cuda::std::is_void<CompareOp>::value)
+  {
+    return thrust::merge_by_key(std::forward<Args>(args)...);
+  }
+  else
+  {
+    // TODO(bgruber): remove next line in C++17 and pass CompareOp{} directly to stable_sort
+    using C = ::cuda::std::__conditional_t<::cuda::std::is_void<CompareOp>::value, thrust::less<T>, CompareOp>;
+    return thrust::merge_by_key(std::forward<Args>(args)..., C{});
+  }


This is a bit annoying to handle, but I want to test calling the thrust API with and without a comparison functor. C++11 makes this additionally hard, since it wants to compile both branches of the if constexpr.

github-actions · 2024-06-10T13:32:06Z

🟨 CI finished in 2h 00m: Pass: 98%/249 | Total: 1d 09h | Avg: 8m 09s | Max: 53m 11s | Hits: 97%/245757

🟨 cub: Pass: 97%/131 | Total: 18h 17m | Avg: 8m 22s | Max: 53m 11s | Hits: 99%/106491

🔍 cpu: amd64 🔍
  🔍 amd64              Pass:  97%/123 | Total: 17h 41m | Avg:  8m 37s | Max: 53m 11s | Hits:  99%/99683 
  🟩 arm64              Pass: 100%/8   | Total: 36m 08s | Avg:  4m 31s | Max:  4m 53s | Hits:  99%/6808  
🔍 ctk: 12.4 🔍
  🟩 11.1               Pass: 100%/15  | Total:  1h 06m | Avg:  4m 26s | Max: 13m 47s | Hits:  99%/11554 
  🟩 11.8               Pass: 100%/3   | Total: 13m 57s | Avg:  4m 39s | Max:  4m 54s | Hits:  99%/2553  
  🔍 12.4               Pass:  97%/113 | Total: 16h 56m | Avg:  8m 59s | Max: 53m 11s | Hits:  99%/92384 
🔍 cudacxx_full: nvcc12.4 🔍
  🟩 clang-cuda17       Pass: 100%/2   | Total:  7m 08s | Avg:  3m 34s | Max:  3m 37s | Hits: 100%/1408  
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 06m | Avg:  4m 26s | Max: 13m 47s | Hits:  99%/11554 
  🟩 nvcc11.8           Pass: 100%/3   | Total: 13m 57s | Avg:  4m 39s | Max:  4m 54s | Hits:  99%/2553  
  🔍 nvcc12.4           Pass:  97%/111 | Total: 16h 49m | Avg:  9m 05s | Max: 53m 11s | Hits:  99%/90976 
🔍 cudacxx_name: nvcc 🔍
  🟩 clang-cuda         Pass: 100%/2   | Total:  7m 08s | Avg:  3m 34s | Max:  3m 37s | Hits: 100%/1408  
  🔍 nvcc               Pass:  97%/129 | Total: 18h 10m | Avg:  8m 27s | Max: 53m 11s | Hits:  99%/105083
🔍 os: ubuntu22.04 🔍
  🟩 ubuntu18.04        Pass: 100%/14  | Total: 52m 57s | Avg:  3m 46s | Max:  4m 19s | Hits:  99%/10859 
  🟩 ubuntu20.04        Pass: 100%/35  | Total:  2h 39m | Avg:  4m 33s | Max:  5m 20s | Hits:  99%/29855 
  🔍 ubuntu22.04        Pass:  96%/76  | Total: 13h 33m | Avg: 10m 42s | Max: 53m 11s | Hits:  98%/61607 
  🟩 windows2022        Pass: 100%/6   | Total:  1h 10m | Avg: 11m 49s | Max: 13m 47s | Hits:  98%/4170  
🟨 cxx_full
  🟩 clang9             Pass: 100%/6   | Total: 26m 32s | Avg:  4m 25s | Max:  5m 15s | Hits: 100%/4884  
  🟩 clang10            Pass: 100%/3   | Total: 15m 43s | Avg:  5m 14s | Max:  5m 20s | Hits: 100%/2559  
  🟩 clang11            Pass: 100%/4   | Total: 18m 19s | Avg:  4m 34s | Max:  4m 50s | Hits: 100%/3412  
  🟩 clang12            Pass: 100%/4   | Total: 17m 46s | Avg:  4m 26s | Max:  4m 39s | Hits: 100%/3412  
  🟩 clang13            Pass: 100%/4   | Total: 18m 03s | Avg:  4m 30s | Max:  4m 43s | Hits: 100%/3412  
  🟩 clang14            Pass: 100%/4   | Total: 18m 02s | Avg:  4m 30s | Max:  5m 05s | Hits: 100%/3412  
  🟩 clang15            Pass: 100%/4   | Total: 18m 33s | Avg:  4m 38s | Max:  4m 51s | Hits: 100%/3404  
  🟩 clang16            Pass: 100%/4   | Total: 18m 24s | Avg:  4m 36s | Max:  4m 40s | Hits: 100%/3404  
  🟨 clang17            Pass:  92%/26  | Total:  5h 19m | Avg: 12m 17s | Max: 26m 35s | Hits: 100%/20130 
  🟩 gcc6               Pass: 100%/2   | Total:  6m 56s | Avg:  3m 28s | Max:  3m 30s | Hits:  99%/1550  
  🟩 gcc7               Pass: 100%/6   | Total: 23m 45s | Avg:  3m 57s | Max:  4m 27s | Hits:  99%/4887  
  🟩 gcc8               Pass: 100%/6   | Total: 24m 54s | Avg:  4m 09s | Max:  4m 24s | Hits:  99%/4887  
  🟩 gcc9               Pass: 100%/6   | Total: 25m 08s | Avg:  4m 11s | Max:  4m 47s | Hits:  99%/4887  
  🟩 gcc10              Pass: 100%/4   | Total: 17m 30s | Avg:  4m 22s | Max:  4m 35s | Hits:  99%/3412  
  🟩 gcc11              Pass: 100%/7   | Total: 31m 44s | Avg:  4m 32s | Max:  4m 54s | Hits:  99%/5957  
  🟩 gcc12              Pass: 100%/4   | Total: 18m 22s | Avg:  4m 35s | Max:  4m 44s | Hits:  99%/3404  
  🟨 gcc13              Pass:  96%/28  | Total:  6h 31m | Avg: 13m 59s | Max: 53m 11s | Hits:  97%/22977 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 15m 30s | Avg:  5m 10s | Max:  5m 24s | Hits: 100%/2331  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 13m 47s | Avg: 13m 47s | Max: 13m 47s | Hits:  98%/695   
  🟩 MSVC14.29          Pass: 100%/2   | Total: 22m 36s | Avg: 11m 18s | Max: 11m 32s | Hits:  98%/1390  
  🟩 MSVC14.39          Pass: 100%/3   | Total: 34m 34s | Avg: 11m 31s | Max: 11m 48s | Hits:  98%/2085  
🟨 cxx_name
  🟨 clang              Pass:  96%/59  | Total:  7h 50m | Avg:  7m 58s | Max: 26m 35s | Hits: 100%/48029 
  🟨 gcc                Pass:  98%/63  | Total:  9h 00m | Avg:  8m 34s | Max: 53m 11s | Hits:  98%/51961 
  🟩 Intel              Pass: 100%/3   | Total: 15m 30s | Avg:  5m 10s | Max:  5m 24s | Hits: 100%/2331  
  🟩 MSVC               Pass: 100%/6   | Total:  1h 10m | Avg: 11m 49s | Max: 13m 47s | Hits:  98%/4170  
🟨 jobs
  🟩 Build              Pass: 100%/99  | Total:  8h 21m | Avg:  5m 04s | Max: 25m 49s | Hits:  99%/81812 
  🟨 DeviceLaunch       Pass:  87%/8   | Total:  2h 06m | Avg: 15m 45s | Max: 20m 44s | Hits:  99%/5957  
  🟩 GraphCapture       Pass: 100%/8   | Total:  2h 00m | Avg: 15m 00s | Max: 17m 02s | Hits:  99%/6808  
  🟨 HostLaunch         Pass:  75%/8   | Total:  2h 01m | Avg: 15m 08s | Max: 26m 35s | Hits:  99%/5106  
  🟩 TestGPU            Pass: 100%/8   | Total:  3h 48m | Avg: 28m 32s | Max: 53m 11s | Hits:  95%/6808  
🟨 std
  🟩 11                 Pass: 100%/34  | Total:  4h 45m | Avg:  8m 24s | Max: 53m 11s | Hits:  98%/28503 
  🟨 14                 Pass:  97%/37  | Total:  4h 47m | Avg:  7m 45s | Max: 28m 30s | Hits:  99%/29737 
  🟨 17                 Pass:  94%/36  | Total:  4h 40m | Avg:  7m 47s | Max: 25m 49s | Hits:  98%/28120 
  🟩 20                 Pass: 100%/24  | Total:  4h 04m | Avg: 10m 10s | Max: 26m 35s | Hits:  99%/20131 
🟨 gpu
  🟨 v100               Pass:  97%/131 | Total: 18h 17m | Avg:  8m 22s | Max: 53m 11s | Hits:  99%/106491
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 13m 57s | Avg:  4m 39s | Max:  4m 54s | Hits:  99%/2553  
  🟩 90a                Pass: 100%/4   | Total: 15m 08s | Avg:  3m 47s | Max:  4m 09s | Hits:  99%/3404

🟩 thrust: Pass: 100%/118 | Total: 15h 32m | Avg: 7m 54s | Max: 23m 58s | Hits: 95%/139266

🟩 cpu
  🟩 amd64              Pass: 100%/110 | Total: 15h 02m | Avg:  8m 12s | Max: 23m 58s | Hits:  95%/129822
  🟩 arm64              Pass: 100%/8   | Total: 30m 00s | Avg:  3m 45s | Max:  4m 04s | Hits:  99%/9444  
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  2h 33m | Avg: 10m 13s | Max: 23m 58s | Hits:  86%/17705 
  🟩 11.8               Pass: 100%/3   | Total: 24m 23s | Avg:  8m 07s | Max: 10m 38s | Hits:  99%/3543  
  🟩 12.4               Pass: 100%/100 | Total: 12h 34m | Avg:  7m 32s | Max: 23m 34s | Hits:  96%/118018
🟩 cudacxx_full
  🟩 clang-cuda17       Pass: 100%/2   | Total:  7m 35s | Avg:  3m 47s | Max:  3m 49s | Hits:  99%/2360  
  🟩 nvcc11.1           Pass: 100%/15  | Total:  2h 33m | Avg: 10m 13s | Max: 23m 58s | Hits:  86%/17705 
  🟩 nvcc11.8           Pass: 100%/3   | Total: 24m 23s | Avg:  8m 07s | Max: 10m 38s | Hits:  99%/3543  
  🟩 nvcc12.4           Pass: 100%/98  | Total: 12h 27m | Avg:  7m 37s | Max: 23m 34s | Hits:  96%/115658
🟩 cudacxx_name
  🟩 clang-cuda         Pass: 100%/2   | Total:  7m 35s | Avg:  3m 47s | Max:  3m 49s | Hits:  99%/2360  
  🟩 nvcc               Pass: 100%/116 | Total: 15h 24m | Avg:  7m 58s | Max: 23m 58s | Hits:  95%/136906
🟩 cxx_full
  🟩 clang9             Pass: 100%/6   | Total: 43m 04s | Avg:  7m 10s | Max: 19m 38s | Hits:  93%/7080  
  🟩 clang10            Pass: 100%/3   | Total: 13m 25s | Avg:  4m 28s | Max:  4m 48s | Hits:  99%/3540  
  🟩 clang11            Pass: 100%/4   | Total: 15m 13s | Avg:  3m 48s | Max:  3m 57s | Hits:  99%/4720  
  🟩 clang12            Pass: 100%/4   | Total: 15m 15s | Avg:  3m 48s | Max:  4m 07s | Hits:  99%/4720  
  🟩 clang13            Pass: 100%/4   | Total: 15m 04s | Avg:  3m 46s | Max:  3m 58s | Hits:  99%/4720  
  🟩 clang14            Pass: 100%/4   | Total: 15m 03s | Avg:  3m 45s | Max:  3m 53s | Hits:  99%/4720  
  🟩 clang15            Pass: 100%/4   | Total: 15m 22s | Avg:  3m 50s | Max:  3m 56s | Hits:  99%/4720  
  🟩 clang16            Pass: 100%/4   | Total: 15m 44s | Avg:  3m 56s | Max:  4m 05s | Hits:  99%/4720  
  🟩 clang17            Pass: 100%/18  | Total:  2h 43m | Avg:  9m 03s | Max: 19m 32s | Hits:  95%/21240 
  🟩 gcc6               Pass: 100%/2   | Total:  6m 31s | Avg:  3m 15s | Max:  3m 19s | Hits:  99%/2360  
  🟩 gcc7               Pass: 100%/6   | Total: 52m 13s | Avg:  8m 42s | Max: 22m 05s | Hits:  88%/7086  
  🟩 gcc8               Pass: 100%/6   | Total: 53m 34s | Avg:  8m 55s | Max: 21m 03s | Hits:  86%/7086  
  🟩 gcc9               Pass: 100%/6   | Total:  1h 23m | Avg: 13m 52s | Max: 23m 58s | Hits:  76%/7086  
  🟩 gcc10              Pass: 100%/4   | Total: 18m 54s | Avg:  4m 43s | Max:  7m 24s | Hits:  99%/4724  
  🟩 gcc11              Pass: 100%/7   | Total: 43m 43s | Avg:  6m 14s | Max: 10m 38s | Hits:  99%/8267  
  🟩 gcc12              Pass: 100%/4   | Total: 20m 14s | Avg:  5m 03s | Max:  8m 11s | Hits:  99%/4724  
  🟩 gcc13              Pass: 100%/20  | Total:  2h 44m | Avg:  8m 13s | Max: 17m 23s | Hits:  98%/23620 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 46m 45s | Avg: 15m 35s | Max: 23m 34s | Hits:  76%/3549  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 14m 48s | Avg: 14m 48s | Max: 14m 48s | Hits:  98%/1176  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 24m 38s | Avg: 12m 19s | Max: 12m 43s | Hits:  98%/2352  
  🟩 MSVC14.39          Pass: 100%/6   | Total:  1h 32m | Avg: 15m 22s | Max: 18m 56s | Hits:  98%/7056  
🟩 cxx_name
  🟩 clang              Pass: 100%/51  | Total:  5h 11m | Avg:  6m 06s | Max: 19m 38s | Hits:  97%/60180 
  🟩 gcc                Pass: 100%/55  | Total:  7h 22m | Avg:  8m 03s | Max: 23m 58s | Hits:  94%/64953 
  🟩 Intel              Pass: 100%/3   | Total: 46m 45s | Avg: 15m 35s | Max: 23m 34s | Hits:  76%/3549  
  🟩 MSVC               Pass: 100%/9   | Total:  2h 11m | Avg: 14m 37s | Max: 18m 56s | Hits:  98%/10584 
🟩 gpu
  🟩 v100               Pass: 100%/118 | Total: 15h 32m | Avg:  7m 54s | Max: 23m 58s | Hits:  95%/139266
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total: 11h 45m | Avg:  7m 07s | Max: 23m 58s | Hits:  94%/116850
  🟩 TestCPU            Pass: 100%/11  | Total:  1h 41m | Avg:  9m 15s | Max: 18m 56s | Hits:  99%/12972 
  🟩 TestGPU            Pass: 100%/8   | Total:  2h 05m | Avg: 15m 42s | Max: 18m 27s | Hits:  99%/9444  
🟩 os
  🟩 ubuntu18.04        Pass: 100%/14  | Total:  2h 18m | Avg:  9m 53s | Max: 23m 58s | Hits:  85%/16529 
  🟩 ubuntu20.04        Pass: 100%/35  | Total:  3h 12m | Avg:  5m 30s | Max: 14m 32s | Hits:  96%/41313 
  🟩 ubuntu22.04        Pass: 100%/60  | Total:  7h 49m | Avg:  7m 49s | Max: 23m 34s | Hits:  96%/70840 
  🟩 windows2022        Pass: 100%/9   | Total:  2h 11m | Avg: 14m 37s | Max: 18m 56s | Hits:  98%/10584 
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 24m 23s | Avg:  8m 07s | Max: 10m 38s | Hits:  99%/3543  
  🟩 90a                Pass: 100%/4   | Total: 13m 22s | Avg:  3m 20s | Max:  3m 28s | Hits:  99%/4724  
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  3h 19m | Avg:  6m 39s | Max: 18m 18s | Hits:  95%/35418 
  🟩 14                 Pass: 100%/34  | Total:  5h 10m | Avg:  9m 08s | Max: 23m 34s | Hits:  93%/40122 
  🟩 17                 Pass: 100%/33  | Total:  4h 34m | Avg:  8m 19s | Max: 23m 58s | Hits:  94%/38946 
  🟩 20                 Pass: 100%/21  | Total:  2h 26m | Avg:  6m 59s | Max: 17m 34s | Hits:  99%/24780

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
+/-	Thrust
	CUDA Experimental

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
+/-	Thrust
	CUDA Experimental

🏃‍ Runner counts (total jobs: 249)

#	Runner
178	`linux-amd64-cpu16`
40	`linux-amd64-gpu-v100-latest-1`
16	`linux-arm64-cpu16`
15	`windows-amd64-cpu16`

github-actions · 2024-06-10T14:58:53Z

🟩 CI finished in 3h 26m: Pass: 100%/249 | Total: 1d 10h | Avg: 8m 20s | Max: 53m 11s | Hits: 97%/248310

🟩 cub: Pass: 100%/131 | Total: 19h 02m | Avg: 8m 43s | Max: 53m 11s | Hits: 99%/109044

🟩 cpu
  🟩 amd64              Pass: 100%/123 | Total: 18h 26m | Avg:  8m 59s | Max: 53m 11s | Hits:  99%/102236
  🟩 arm64              Pass: 100%/8   | Total: 36m 08s | Avg:  4m 31s | Max:  4m 53s | Hits:  99%/6808  
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 06m | Avg:  4m 26s | Max: 13m 47s | Hits:  99%/11554 
  🟩 11.8               Pass: 100%/3   | Total: 13m 57s | Avg:  4m 39s | Max:  4m 54s | Hits:  99%/2553  
  🟩 12.4               Pass: 100%/113 | Total: 17h 42m | Avg:  9m 23s | Max: 53m 11s | Hits:  99%/94937 
🟩 cudacxx_full
  🟩 clang-cuda17       Pass: 100%/2   | Total:  7m 08s | Avg:  3m 34s | Max:  3m 37s | Hits: 100%/1408  
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 06m | Avg:  4m 26s | Max: 13m 47s | Hits:  99%/11554 
  🟩 nvcc11.8           Pass: 100%/3   | Total: 13m 57s | Avg:  4m 39s | Max:  4m 54s | Hits:  99%/2553  
  🟩 nvcc12.4           Pass: 100%/111 | Total: 17h 34m | Avg:  9m 30s | Max: 53m 11s | Hits:  99%/93529 
🟩 cudacxx_name
  🟩 clang-cuda         Pass: 100%/2   | Total:  7m 08s | Avg:  3m 34s | Max:  3m 37s | Hits: 100%/1408  
  🟩 nvcc               Pass: 100%/129 | Total: 18h 55m | Avg:  8m 48s | Max: 53m 11s | Hits:  99%/107636
🟩 cxx_full
  🟩 clang9             Pass: 100%/6   | Total: 26m 32s | Avg:  4m 25s | Max:  5m 15s | Hits: 100%/4884  
  🟩 clang10            Pass: 100%/3   | Total: 15m 43s | Avg:  5m 14s | Max:  5m 20s | Hits: 100%/2559  
  🟩 clang11            Pass: 100%/4   | Total: 18m 19s | Avg:  4m 34s | Max:  4m 50s | Hits: 100%/3412  
  🟩 clang12            Pass: 100%/4   | Total: 17m 46s | Avg:  4m 26s | Max:  4m 39s | Hits: 100%/3412  
  🟩 clang13            Pass: 100%/4   | Total: 18m 03s | Avg:  4m 30s | Max:  4m 43s | Hits: 100%/3412  
  🟩 clang14            Pass: 100%/4   | Total: 18m 02s | Avg:  4m 30s | Max:  5m 05s | Hits: 100%/3412  
  🟩 clang15            Pass: 100%/4   | Total: 18m 33s | Avg:  4m 38s | Max:  4m 51s | Hits: 100%/3404  
  🟩 clang16            Pass: 100%/4   | Total: 18m 24s | Avg:  4m 36s | Max:  4m 40s | Hits: 100%/3404  
  🟩 clang17            Pass: 100%/26  | Total:  5h 55m | Avg: 13m 41s | Max: 26m 35s | Hits: 100%/21832 
  🟩 gcc6               Pass: 100%/2   | Total:  6m 56s | Avg:  3m 28s | Max:  3m 30s | Hits:  99%/1550  
  🟩 gcc7               Pass: 100%/6   | Total: 23m 45s | Avg:  3m 57s | Max:  4m 27s | Hits:  99%/4887  
  🟩 gcc8               Pass: 100%/6   | Total: 24m 54s | Avg:  4m 09s | Max:  4m 24s | Hits:  99%/4887  
  🟩 gcc9               Pass: 100%/6   | Total: 25m 08s | Avg:  4m 11s | Max:  4m 47s | Hits:  99%/4887  
  🟩 gcc10              Pass: 100%/4   | Total: 17m 30s | Avg:  4m 22s | Max:  4m 35s | Hits:  99%/3412  
  🟩 gcc11              Pass: 100%/7   | Total: 31m 44s | Avg:  4m 32s | Max:  4m 54s | Hits:  99%/5957  
  🟩 gcc12              Pass: 100%/4   | Total: 18m 22s | Avg:  4m 35s | Max:  4m 44s | Hits:  99%/3404  
  🟩 gcc13              Pass: 100%/28  | Total:  6h 40m | Avg: 14m 19s | Max: 53m 11s | Hits:  97%/23828 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 15m 30s | Avg:  5m 10s | Max:  5m 24s | Hits: 100%/2331  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 13m 47s | Avg: 13m 47s | Max: 13m 47s | Hits:  98%/695   
  🟩 MSVC14.29          Pass: 100%/2   | Total: 22m 36s | Avg: 11m 18s | Max: 11m 32s | Hits:  98%/1390  
  🟩 MSVC14.39          Pass: 100%/3   | Total: 34m 34s | Avg: 11m 31s | Max: 11m 48s | Hits:  98%/2085  
🟩 cxx_name
  🟩 clang              Pass: 100%/59  | Total:  8h 27m | Avg:  8m 35s | Max: 26m 35s | Hits: 100%/49731 
  🟩 gcc                Pass: 100%/63  | Total:  9h 09m | Avg:  8m 43s | Max: 53m 11s | Hits:  98%/52812 
  🟩 Intel              Pass: 100%/3   | Total: 15m 30s | Avg:  5m 10s | Max:  5m 24s | Hits: 100%/2331  
  🟩 MSVC               Pass: 100%/6   | Total:  1h 10m | Avg: 11m 49s | Max: 13m 47s | Hits:  98%/4170  
🟩 gpu
  🟩 v100               Pass: 100%/131 | Total: 19h 02m | Avg:  8m 43s | Max: 53m 11s | Hits:  99%/109044
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total:  8h 21m | Avg:  5m 04s | Max: 25m 49s | Hits:  99%/81812 
  🟩 DeviceLaunch       Pass: 100%/8   | Total:  2h 25m | Avg: 18m 12s | Max: 24m 15s | Hits:  99%/6808  
  🟩 GraphCapture       Pass: 100%/8   | Total:  2h 00m | Avg: 15m 00s | Max: 17m 02s | Hits:  99%/6808  
  🟩 HostLaunch         Pass: 100%/8   | Total:  2h 26m | Avg: 18m 22s | Max: 26m 35s | Hits:  99%/6808  
  🟩 TestGPU            Pass: 100%/8   | Total:  3h 48m | Avg: 28m 32s | Max: 53m 11s | Hits:  95%/6808  
🟩 os
  🟩 ubuntu18.04        Pass: 100%/14  | Total: 52m 57s | Avg:  3m 46s | Max:  4m 19s | Hits:  99%/10859 
  🟩 ubuntu20.04        Pass: 100%/35  | Total:  2h 39m | Avg:  4m 33s | Max:  5m 20s | Hits:  99%/29855 
  🟩 ubuntu22.04        Pass: 100%/76  | Total: 14h 19m | Avg: 11m 18s | Max: 53m 11s | Hits:  98%/64160 
  🟩 windows2022        Pass: 100%/6   | Total:  1h 10m | Avg: 11m 49s | Max: 13m 47s | Hits:  98%/4170  
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 13m 57s | Avg:  4m 39s | Max:  4m 54s | Hits:  99%/2553  
  🟩 90a                Pass: 100%/4   | Total: 15m 08s | Avg:  3m 47s | Max:  4m 09s | Hits:  99%/3404  
🟩 std
  🟩 11                 Pass: 100%/34  | Total:  4h 45m | Avg:  8m 24s | Max: 53m 11s | Hits:  98%/28503 
  🟩 14                 Pass: 100%/37  | Total:  4h 56m | Avg:  8m 00s | Max: 28m 30s | Hits:  99%/30588 
  🟩 17                 Pass: 100%/36  | Total:  5h 16m | Avg:  8m 47s | Max: 25m 49s | Hits:  98%/29822 
  🟩 20                 Pass: 100%/24  | Total:  4h 04m | Avg: 10m 10s | Max: 26m 35s | Hits:  99%/20131

🟩 thrust: Pass: 100%/118 | Total: 15h 32m | Avg: 7m 54s | Max: 23m 58s | Hits: 95%/139266

🟩 cpu
  🟩 amd64              Pass: 100%/110 | Total: 15h 02m | Avg:  8m 12s | Max: 23m 58s | Hits:  95%/129822
  🟩 arm64              Pass: 100%/8   | Total: 30m 00s | Avg:  3m 45s | Max:  4m 04s | Hits:  99%/9444  
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  2h 33m | Avg: 10m 13s | Max: 23m 58s | Hits:  86%/17705 
  🟩 11.8               Pass: 100%/3   | Total: 24m 23s | Avg:  8m 07s | Max: 10m 38s | Hits:  99%/3543  
  🟩 12.4               Pass: 100%/100 | Total: 12h 34m | Avg:  7m 32s | Max: 23m 34s | Hits:  96%/118018
🟩 cudacxx_full
  🟩 clang-cuda17       Pass: 100%/2   | Total:  7m 35s | Avg:  3m 47s | Max:  3m 49s | Hits:  99%/2360  
  🟩 nvcc11.1           Pass: 100%/15  | Total:  2h 33m | Avg: 10m 13s | Max: 23m 58s | Hits:  86%/17705 
  🟩 nvcc11.8           Pass: 100%/3   | Total: 24m 23s | Avg:  8m 07s | Max: 10m 38s | Hits:  99%/3543  
  🟩 nvcc12.4           Pass: 100%/98  | Total: 12h 27m | Avg:  7m 37s | Max: 23m 34s | Hits:  96%/115658
🟩 cudacxx_name
  🟩 clang-cuda         Pass: 100%/2   | Total:  7m 35s | Avg:  3m 47s | Max:  3m 49s | Hits:  99%/2360  
  🟩 nvcc               Pass: 100%/116 | Total: 15h 24m | Avg:  7m 58s | Max: 23m 58s | Hits:  95%/136906
🟩 cxx_full
  🟩 clang9             Pass: 100%/6   | Total: 43m 04s | Avg:  7m 10s | Max: 19m 38s | Hits:  93%/7080  
  🟩 clang10            Pass: 100%/3   | Total: 13m 25s | Avg:  4m 28s | Max:  4m 48s | Hits:  99%/3540  
  🟩 clang11            Pass: 100%/4   | Total: 15m 13s | Avg:  3m 48s | Max:  3m 57s | Hits:  99%/4720  
  🟩 clang12            Pass: 100%/4   | Total: 15m 15s | Avg:  3m 48s | Max:  4m 07s | Hits:  99%/4720  
  🟩 clang13            Pass: 100%/4   | Total: 15m 04s | Avg:  3m 46s | Max:  3m 58s | Hits:  99%/4720  
  🟩 clang14            Pass: 100%/4   | Total: 15m 03s | Avg:  3m 45s | Max:  3m 53s | Hits:  99%/4720  
  🟩 clang15            Pass: 100%/4   | Total: 15m 22s | Avg:  3m 50s | Max:  3m 56s | Hits:  99%/4720  
  🟩 clang16            Pass: 100%/4   | Total: 15m 44s | Avg:  3m 56s | Max:  4m 05s | Hits:  99%/4720  
  🟩 clang17            Pass: 100%/18  | Total:  2h 43m | Avg:  9m 03s | Max: 19m 32s | Hits:  95%/21240 
  🟩 gcc6               Pass: 100%/2   | Total:  6m 31s | Avg:  3m 15s | Max:  3m 19s | Hits:  99%/2360  
  🟩 gcc7               Pass: 100%/6   | Total: 52m 13s | Avg:  8m 42s | Max: 22m 05s | Hits:  88%/7086  
  🟩 gcc8               Pass: 100%/6   | Total: 53m 34s | Avg:  8m 55s | Max: 21m 03s | Hits:  86%/7086  
  🟩 gcc9               Pass: 100%/6   | Total:  1h 23m | Avg: 13m 52s | Max: 23m 58s | Hits:  76%/7086  
  🟩 gcc10              Pass: 100%/4   | Total: 18m 54s | Avg:  4m 43s | Max:  7m 24s | Hits:  99%/4724  
  🟩 gcc11              Pass: 100%/7   | Total: 43m 43s | Avg:  6m 14s | Max: 10m 38s | Hits:  99%/8267  
  🟩 gcc12              Pass: 100%/4   | Total: 20m 14s | Avg:  5m 03s | Max:  8m 11s | Hits:  99%/4724  
  🟩 gcc13              Pass: 100%/20  | Total:  2h 44m | Avg:  8m 13s | Max: 17m 23s | Hits:  98%/23620 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 46m 45s | Avg: 15m 35s | Max: 23m 34s | Hits:  76%/3549  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 14m 48s | Avg: 14m 48s | Max: 14m 48s | Hits:  98%/1176  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 24m 38s | Avg: 12m 19s | Max: 12m 43s | Hits:  98%/2352  
  🟩 MSVC14.39          Pass: 100%/6   | Total:  1h 32m | Avg: 15m 22s | Max: 18m 56s | Hits:  98%/7056  
🟩 cxx_name
  🟩 clang              Pass: 100%/51  | Total:  5h 11m | Avg:  6m 06s | Max: 19m 38s | Hits:  97%/60180 
  🟩 gcc                Pass: 100%/55  | Total:  7h 22m | Avg:  8m 03s | Max: 23m 58s | Hits:  94%/64953 
  🟩 Intel              Pass: 100%/3   | Total: 46m 45s | Avg: 15m 35s | Max: 23m 34s | Hits:  76%/3549  
  🟩 MSVC               Pass: 100%/9   | Total:  2h 11m | Avg: 14m 37s | Max: 18m 56s | Hits:  98%/10584 
🟩 gpu
  🟩 v100               Pass: 100%/118 | Total: 15h 32m | Avg:  7m 54s | Max: 23m 58s | Hits:  95%/139266
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total: 11h 45m | Avg:  7m 07s | Max: 23m 58s | Hits:  94%/116850
  🟩 TestCPU            Pass: 100%/11  | Total:  1h 41m | Avg:  9m 15s | Max: 18m 56s | Hits:  99%/12972 
  🟩 TestGPU            Pass: 100%/8   | Total:  2h 05m | Avg: 15m 42s | Max: 18m 27s | Hits:  99%/9444  
🟩 os
  🟩 ubuntu18.04        Pass: 100%/14  | Total:  2h 18m | Avg:  9m 53s | Max: 23m 58s | Hits:  85%/16529 
  🟩 ubuntu20.04        Pass: 100%/35  | Total:  3h 12m | Avg:  5m 30s | Max: 14m 32s | Hits:  96%/41313 
  🟩 ubuntu22.04        Pass: 100%/60  | Total:  7h 49m | Avg:  7m 49s | Max: 23m 34s | Hits:  96%/70840 
  🟩 windows2022        Pass: 100%/9   | Total:  2h 11m | Avg: 14m 37s | Max: 18m 56s | Hits:  98%/10584 
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 24m 23s | Avg:  8m 07s | Max: 10m 38s | Hits:  99%/3543  
  🟩 90a                Pass: 100%/4   | Total: 13m 22s | Avg:  3m 20s | Max:  3m 28s | Hits:  99%/4724  
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  3h 19m | Avg:  6m 39s | Max: 18m 18s | Hits:  95%/35418 
  🟩 14                 Pass: 100%/34  | Total:  5h 10m | Avg:  9m 08s | Max: 23m 34s | Hits:  93%/40122 
  🟩 17                 Pass: 100%/33  | Total:  4h 34m | Avg:  8m 19s | Max: 23m 58s | Hits:  94%/38946 
  🟩 20                 Pass: 100%/21  | Total:  2h 26m | Avg:  6m 59s | Max: 17m 34s | Hits:  99%/24780

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
+/-	Thrust
	CUDA Experimental

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
+/-	Thrust
	CUDA Experimental

🏃‍ Runner counts (total jobs: 249)

#	Runner
178	`linux-amd64-cpu16`
40	`linux-amd64-gpu-v100-latest-1`
16	`linux-arm64-cpu16`
15	`windows-amd64-cpu16`

miscco · 2024-06-11T08:34:10Z

thrust/testing/merge_by_key.cu

-  ref_key[5] = 4; ref_val[5] = 42;
-  ref_key[6] = 4; ref_val[6] = 13;
-  // clang-format on
+  const Vector a_key{0, 2, 4}, a_val{13, 7, 42}, b_key{0, 3, 3, 4}, b_val{42, 42, 7, 13};


Important: We have never written it out, but AFAIK we strongly encourage one line per variable

There are a lot of tests written like that. I will keep it in mind for future PRs!

miscco · 2024-06-11T08:37:04Z

thrust/testing/merge_by_key.cu

    thrust::host_vector<T> h_a_keys(random_keys.begin(), random_keys.begin() + size_a);
    thrust::host_vector<T> h_b_keys(random_keys.begin() + size_a, random_keys.end());

-    thrust::host_vector<T> h_a_vals(random_vals.begin(), random_vals.begin() + size_a);
-    thrust::host_vector<T> h_b_vals(random_vals.begin() + size_a, random_vals.end());
+    const thrust::host_vector<T> h_a_vals(random_vals.begin(), random_vals.begin() + size_a);
+    const thrust::host_vector<T> h_b_vals(random_vals.begin() + size_a, random_vals.end());


I am wondering, we are always just sorting subranges of the same vector. Could we just use a cuda::std::span and avoid the separate vectors?

Just kidding we still have C++11

miscco · 2024-06-11T08:37:50Z

thrust/testing/unittest/special_types.h

+  my_system() = delete;
+


Nitpick: I believe that is superfluous

bernhardmgruber changed the title ~~Clean up merge_by_key and merge_key_value tests~~ Clean up merge_by_key and merge_key_value tests Jun 7, 2024

bernhardmgruber added the thrust For all items related to Thrust. label Jun 7, 2024

bernhardmgruber force-pushed the cleanup_merge_tests branch 4 times, most recently from 95c3a71 to f1f1866 Compare June 10, 2024 09:07

bernhardmgruber marked this pull request as ready for review June 10, 2024 09:08

bernhardmgruber requested review from a team as code owners June 10, 2024 09:08

bernhardmgruber requested review from miscco and gonidelis June 10, 2024 09:08

Clean up merge_by_key and merge_key_value tests

05934a7

bernhardmgruber force-pushed the cleanup_merge_tests branch from f1f1866 to 05934a7 Compare June 10, 2024 11:28

bernhardmgruber commented Jun 10, 2024

View reviewed changes

bernhardmgruber mentioned this pull request Jun 10, 2024

Port thrust::merge[_by_key] to CUB #1817

Merged

9 tasks

bernhardmgruber enabled auto-merge (squash) June 10, 2024 17:43

miscco approved these changes Jun 11, 2024

View reviewed changes

bernhardmgruber merged commit 9b85fd3 into NVIDIA:main Jun 11, 2024
552 checks passed

bernhardmgruber deleted the cleanup_merge_tests branch June 11, 2024 08:54

bernhardmgruber mentioned this pull request Jun 11, 2024

Cleanup thrust test special types #1837

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up `merge_by_key` and `merge_key_value` tests #1824

Clean up `merge_by_key` and `merge_key_value` tests #1824

bernhardmgruber commented Jun 7, 2024

bernhardmgruber Jun 10, 2024

github-actions bot commented Jun 10, 2024

🟨 cub: Pass: 97%/131 | Total: 18h 17m | Avg: 8m 22s | Max: 53m 11s | Hits: 99%/106491

🟩 thrust: Pass: 100%/118 | Total: 15h 32m | Avg: 7m 54s | Max: 23m 58s | Hits: 95%/139266

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 249)

github-actions bot commented Jun 10, 2024

🟩 cub: Pass: 100%/131 | Total: 19h 02m | Avg: 8m 43s | Max: 53m 11s | Hits: 99%/109044

🟩 thrust: Pass: 100%/118 | Total: 15h 32m | Avg: 7m 54s | Max: 23m 58s | Hits: 95%/139266

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 249)

miscco Jun 11, 2024

bernhardmgruber Jun 11, 2024

miscco Jun 11, 2024

miscco Jun 11, 2024 •

edited

Loading

bernhardmgruber Jun 11, 2024

Clean up merge_by_key and merge_key_value tests #1824

Clean up merge_by_key and merge_key_value tests #1824

Conversation

bernhardmgruber commented Jun 7, 2024

bernhardmgruber Jun 10, 2024

Choose a reason for hiding this comment

github-actions bot commented Jun 10, 2024

🟨 cub: Pass: 97%/131 | Total: 18h 17m | Avg: 8m 22s | Max: 53m 11s | Hits: 99%/106491

🟩 thrust: Pass: 100%/118 | Total: 15h 32m | Avg: 7m 54s | Max: 23m 58s | Hits: 95%/139266

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 249)

github-actions bot commented Jun 10, 2024

🟩 cub: Pass: 100%/131 | Total: 19h 02m | Avg: 8m 43s | Max: 53m 11s | Hits: 99%/109044

🟩 thrust: Pass: 100%/118 | Total: 15h 32m | Avg: 7m 54s | Max: 23m 58s | Hits: 95%/139266

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 249)

miscco Jun 11, 2024

Choose a reason for hiding this comment

bernhardmgruber Jun 11, 2024

Choose a reason for hiding this comment

miscco Jun 11, 2024

Choose a reason for hiding this comment

miscco Jun 11, 2024 • edited Loading

Choose a reason for hiding this comment

bernhardmgruber Jun 11, 2024

Choose a reason for hiding this comment

Clean up `merge_by_key` and `merge_key_value` tests #1824

Clean up `merge_by_key` and `merge_key_value` tests #1824

miscco Jun 11, 2024 •

edited

Loading