Test combined internal/user-side use of NVTX #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
force-pushed
the
nvtx_userside_use
branch
from
a5e09f9 to
7adee3e
Compare
bernhardmgruber
commented
May 2, 2024
cub/test/CMakeLists.txt
Outdated
Comment on lines
29
to
30
| CPMAddPackage(NAME NVTX GITHUB_REPOSITORY NVIDIA/NVTX GIT_TAG release-v3 DOWNLOAD_ONLY True) | ||
| add_subdirectory(${NVTX_SOURCE_DIR}/c ${NVTX_BINARY_DIR}/c) |
There was a problem hiding this comment.
Is this the best way to obtain a dependency without a top-level CMakeLists.txt?
cub/test/CMakeLists.txt
Outdated
Comment on lines
282
to
284
| if (${test_src} MATCHES "test_nvtx_in_usercode.cu") | ||
| target_link_libraries(${test_target} nvtx3-cpp) | ||
| endif() |
There was a problem hiding this comment.
How can I best add a library dependency to only a single test?
There was a problem hiding this comment.
There was a problem hiding this comment.
Alright, I updated my changeset.
There was a problem hiding this comment.
This is indeed the best way for now. Thrust has a fancier mechanism that lets us add a test-specific ${test_name}.cmake file that gets loaded and applied to the test targets, but that doesn't currently exist in CUB.
bernhardmgruber
force-pushed
the
nvtx_userside_use
branch
2 times, most recently
from
031833d to
a2a7a6f
Compare
alliepiper
requested changes
May 2, 2024
bernhardmgruber
force-pushed
the
nvtx_userside_use
branch
2 times, most recently
from
8d44a76 to
8bacb3f
Compare
Co-authored-by: Allison Piper <[email protected]>
bernhardmgruber
force-pushed
the
nvtx_userside_use
branch
from
8bacb3f to
c10f9d9
Compare
alliepiper
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test where the NVTX API is used internally by CUB via the vendored nvtx3.hpp, and a second time in the test's main file with headers cloned from the NVTX GitHub repository. The test verifies that CUB's use of NVTX does not break users using NVTX beside CUB.