Segmented sort test fix #1591
Merged
Segmented sort test fix #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unspecified segment generator was randomly writing 0s into the begin/end offset arrays, while num_items was computed as `end_offsets.back() + 243`, intended to pad the key/value arrays with a trailing unspecified segment. If one of the randomly zeroed offsets was the last segment in the array, the num_items would be set to 243, which is less than many of the valid segment ranges, causing out-of-bounds reads/writes and corrupting memory. Fixed this by removing the last segment from consideration when generating the zeroed segments.
elstehle
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The unspecified segment generator was randomly writing 0s into the begin/end offset arrays, while num_items was computed as
end_offsets.back() + 243, intended to pad the key/value arrays with a trailing unspecified segment.If one of the randomly zeroed offsets was the last segment in the array, the num_items would be set to 243, which is less than many of the valid segment ranges, causing out-of-bounds reads/writes and corrupting memory.
Fixed this by removing the last segment from consideration when generating the zeroed segments.
Ref #1380