-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cuda::mr::managed_memory_resource
#1579
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuda::mr::managed_memory_resource
975cfde
to
93dab9c
Compare
harrism
requested changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to go. A few suggestions.
libcudacxx/include/cuda/__memory_resource/cuda_managed_memory_resource.h
Outdated
Show resolved
Hide resolved
libcudacxx/include/cuda/__memory_resource/cuda_managed_memory_resource.h
Outdated
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/cuda/memory_resource/cuda_managed_memory_resource/allocate.pass.cpp
Outdated
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/cuda/memory_resource/cuda_managed_memory_resource/equality.pass.cpp
Outdated
Show resolved
Hide resolved
harrism
reviewed
Apr 4, 2024
harrism
approved these changes
Apr 4, 2024
griwes
approved these changes
Apr 5, 2024
5df98a1
to
7c86598
Compare
b5563d9
to
fa73fae
Compare
fa73fae
to
a79affb
Compare
Fixes Implement a memory_resource using `cudaMallocManaged` and `cudaFree` NVIDIA#1515
a79affb
to
fc486ab
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Implement a memory_resource using
cudaMallocManaged
andcudaFree
#1515Respin of #1556 due to stacked branch issues