Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cuda::mr::managed_memory_resource #1579

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Apr 2, 2024

Fixes Implement a memory_resource using cudaMallocManaged and cudaFree #1515

Respin of #1556 due to stacked branch issues

@miscco miscco requested review from a team as code owners April 2, 2024 18:39
@miscco miscco requested review from ericniebler and griwes April 2, 2024 18:39
@miscco miscco changed the title Cuda_managed_memory_resource Implement cuda::mr::managed_memory_resource Apr 2, 2024
@miscco miscco changed the base branch from main to pull-request/1578 April 2, 2024 18:40
@miscco miscco requested a review from harrism April 2, 2024 18:42
@miscco miscco added libcu++ For all items related to libcu++ feature request New feature or request. labels Apr 2, 2024
@miscco miscco linked an issue Apr 2, 2024 that may be closed by this pull request
@miscco miscco force-pushed the cuda_managed_memory_resource branch 3 times, most recently from 975cfde to 93dab9c Compare April 3, 2024 15:29
Copy link
Contributor

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to go. A few suggestions.

@copy-pr-bot copy-pr-bot bot force-pushed the pull-request/1578 branch 3 times, most recently from 5df98a1 to 7c86598 Compare April 5, 2024 20:40
@miscco miscco force-pushed the cuda_managed_memory_resource branch from b5563d9 to fa73fae Compare April 11, 2024 09:26
@miscco miscco changed the base branch from pull-request/1578 to main April 11, 2024 19:00
@miscco miscco requested review from a team as code owners April 11, 2024 19:00
@miscco miscco requested review from wmaxey and elstehle April 11, 2024 19:00
@miscco miscco force-pushed the cuda_managed_memory_resource branch from fa73fae to a79affb Compare April 12, 2024 06:18
Fixes Implement a memory_resource using `cudaMallocManaged` and `cudaFree` NVIDIA#1515
@miscco miscco force-pushed the cuda_managed_memory_resource branch from a79affb to fc486ab Compare April 12, 2024 07:04
@miscco miscco enabled auto-merge (squash) April 12, 2024 07:04
@miscco miscco merged commit aa15c2d into NVIDIA:main Apr 12, 2024
586 checks passed
@miscco miscco deleted the cuda_managed_memory_resource branch April 12, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request. libcu++ For all items related to libcu++
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA]: Implement a memory_resource using cudaMallocManaged and cudaFree
3 participants