Implement cuda::mr::cuda_memory_resource
#1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
added
feature request
|
So my review is gone. Let's avoid "stacked PRs". Losing reviewer history is a big loss in productivity. |
It was more my bad. I forgot to change the target branch before I merged the first PR |
|
Also the review is still there #1513 |
miscco
force-pushed
the
cuda_memory_resource
branch
from
2b30982 to
c701e83
Compare
jrhemstad
reviewed
Apr 3, 2024
libcudacxx/include/cuda/__memory_resource/cuda_memory_resource.h
Outdated
Show resolved
Hide resolved
Please respond to this unanswered comment: #1513 (comment) |
Addressed the comment |
harrism
approved these changes
Apr 4, 2024
griwes
approved these changes
Apr 5, 2024
miscco
force-pushed
the
cuda_memory_resource
branch
6 times, most recently
from
5df98a1 to
7c86598
Compare
jrhemstad
reviewed
Apr 5, 2024
| * @throw cuda::cuda_error of the returned error code | ||
| * @return Pointer to the newly allocated memory | ||
| */ | ||
| void* allocate(const size_t __bytes, const size_t __alignment = default_cuda_malloc_alignment) const |
There was a problem hiding this comment.
question: Should allocate in all our resources always be nodiscard?
miscco
commented
Apr 8, 2024
miscco
commented
Apr 8, 2024
miscco
force-pushed
the
cuda_memory_resource
branch
from
b367f31 to
83a2dd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1512
I managed to close #1513 because I did not change the target branch before merging
Stacked PRs are "fun"