Improve implementation of destructible
#157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
force-pushed
the
improve_destructible_concept
branch
3 times, most recently
from
a61f684 to
9b484f6
Compare
We did not apply this for old gcc compilers, but it turns out that they will fall over more complex ranges concepts later. We can alleviate this by reusing `is_destructible` and generally clean the implementation up.
miscco
force-pushed
the
improve_destructible_concept
branch
from
9b484f6 to
caf02fb
Compare
24 tasks
24 tasks
|
I'm a little late to the game here, but this looks good. Clang, NVHPC, and MSVC have an intrinsic for this that we could use to speed things up: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our implementation worked around some issues with older gcc.
However, those break when used with more complex ranges concepts. We can work around this by just falling back to
is_destructiblein that case and go our merry way.While we are at it also simplify the implementation a bit and add
_LIBCUDACXX_INLINE_VAR