Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Remove symlinks from libcudacxx #143

Closed
1 task done
wmaxey opened this issue Jun 28, 2023 · 0 comments · Fixed by #1075
Closed
1 task done

[FEA]: Remove symlinks from libcudacxx #143

wmaxey opened this issue Jun 28, 2023 · 0 comments · Fixed by #1075
Labels
infrastructure Shared CMake, github, etc infrastructure libcu++ For all items related to libcu++

Comments

@wmaxey
Copy link
Member

wmaxey commented Jun 28, 2023

Is this a duplicate?

Area

libcu++

Is your feature request related to a problem? Please describe.

There are various other SCMs that we integrate with and the symlinks in libcudacxx are problematic.

Describe the solution you'd like

I think the simplest thing is to just delete the utils and .upstream-tests directories and rely on the proper folders instead.

Describe alternatives you've considered

No response

Additional context

No response
@wmaxey wmaxey added libcu++ For all items related to libcu++ infrastructure Shared CMake, github, etc infrastructure labels Jun 28, 2023
@wmaxey wmaxey added this to CCCL Jun 28, 2023
@github-project-automation github-project-automation bot moved this to Todo in CCCL Jun 28, 2023
@wmaxey wmaxey changed the title [FEA]: [FEA]: Remove symlinks from libcudacxx Jul 17, 2023
@wmaxey wmaxey moved this from Todo to In Progress in CCCL Nov 8, 2023
@wmaxey wmaxey mentioned this issue Nov 9, 2023
Merged
2 tasks
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Progress to In Review in CCCL Nov 9, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Nov 14, 2023
@wmaxey wmaxey mentioned this issue Nov 14, 2023
Merged
alliepiper pushed a commit to alliepiper/cccl that referenced this issue Mar 28, 2024
@robertmaynard @miscco
write_git_revision_file must be used in same CMakeLists as consumer (N…
e47d7ac 
…VIDIA#143)

* write_git_revision_file must be used in same CMakeLists as consumer

So we can't have this in the rapids-cmake init function.

* Fix whitespace damage

---------

Co-authored-by: Michael Schellenberger Costa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Shared CMake, github, etc infrastructure libcu++ For all items related to libcu++
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove libcudacxx symlinks NVIDIA/cccl
1 participant
@wmaxey