-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: thrust::pair is not trivially copyable in CCCL branch/2.3.x #1246
Labels
bug
Something isn't working right.
Comments
2 tasks
miscco
added a commit
to miscco/cccl
that referenced
this issue
Jan 5, 2024
trivially copyable is a requirement for memcpy. We want to ensure that our pair implementation satisfies that whenever possible. This is especially important for thrust::pair as that is used in rmm extensively. Fixes NVIDIA#1246
miscco
added a commit
to miscco/cccl
that referenced
this issue
Jan 5, 2024
trivially copyable is a requirement for memcpy. We want to ensure that our pair implementation satisfies that whenever possible. This is especially important for thrust::pair as that is used in rmm extensively. Fixes NVIDIA#1246
miscco
added a commit
to miscco/cccl
that referenced
this issue
Jan 5, 2024
trivially copyable is a requirement for memcpy. We want to ensure that our pair implementation satisfies that whenever possible. This is especially important for thrust::pair as that is used in rmm extensively. Fixes NVIDIA#1246
miscco
added a commit
to miscco/cccl
that referenced
this issue
Jan 5, 2024
trivially copyable is a requirement for memcpy. We want to ensure that our pair implementation satisfies that whenever possible. This is especially important for thrust::pair as that is used in rmm extensively. Fixes NVIDIA#1246
miscco
added a commit
that referenced
this issue
Jan 18, 2024
trivially copyable is a requirement for memcpy. We want to ensure that our pair implementation satisfies that whenever possible. This is especially important for thrust::pair as that is used in rmm extensively. Fixes #1246 Co-authored-by: Georgy Evtushenko <[email protected]>
miscco
added a commit
to miscco/cccl
that referenced
this issue
Jan 18, 2024
…IA#1249) trivially copyable is a requirement for memcpy. We want to ensure that our pair implementation satisfies that whenever possible. This is especially important for thrust::pair as that is used in rmm extensively. Fixes NVIDIA#1246 Co-authored-by: Georgy Evtushenko <[email protected]>
miscco
added a commit
to miscco/cccl
that referenced
this issue
Jan 18, 2024
…IA#1249) trivially copyable is a requirement for memcpy. We want to ensure that our pair implementation satisfies that whenever possible. This is especially important for thrust::pair as that is used in rmm extensively. Fixes NVIDIA#1246 Co-authored-by: Georgy Evtushenko <[email protected]>
jrhemstad
pushed a commit
that referenced
this issue
Jan 18, 2024
* Ensure that `cuda::std::pair` is potentially trivially copyable (#1249) trivially copyable is a requirement for memcpy. We want to ensure that our pair implementation satisfies that whenever possible. This is especially important for thrust::pair as that is used in rmm extensively. Fixes #1246 Co-authored-by: Georgy Evtushenko <[email protected]> * Mark test as passing --------- Co-authored-by: Georgy Evtushenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this a duplicate?
Type of Bug
Compile-time Error
Component
Thrust
Describe the bug
The
thrust::pair
class was trivially copyable in CCCL 2.2.0 but is not trivially copyable inbranch/2.3.x
. I suspect #262 is the PR that introduced this change (bug?).This leads to compilation failures in RAPIDS cuDF because RMM requires
rmm::device_uvector
to use trivially copyable types. For example: https://github.com/rapidsai/cudf/actions/runs/7403019153/job/20142041800?pr=14704#step:8:1714How to Reproduce
Switch between CCCL 2.2.0 and trunk. 2.2.0 passes, but trunk fails.
https://godbolt.org/z/oeEKa5577
Also see rapidsai/cudf#14704
Expected behavior
thrust::pair
behavior should not change (it should be trivially copyable in CCCL trunk).Reproduction link
https://godbolt.org/z/oeEKa5577
Operating System
No response
nvidia-smi output
No response
NVCC version
No response
The text was updated successfully, but these errors were encountered: