[NeMo-UX] Add distributed checkpointing unit tests #9922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* add dist checkpointing tests Signed-off-by: ashors1 <[email protected]> * fix recursion bug Signed-off-by: ashors1 <[email protected]> * raise original AttributeError Signed-off-by: ashors1 <[email protected]> * dist checkpoint test fixes Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> * set async_save from strategy to make checkpoint_io more robust Signed-off-by: ashors1 <[email protected]> * update async save test Signed-off-by: ashors1 <[email protected]> * fixes Signed-off-by: ashors1 <[email protected]> * clean up and address comments Signed-off-by: ashors1 <[email protected]> * fix mock datamodule Signed-off-by: ashors1 <[email protected]> * fix qk layer scaling setting Signed-off-by: ashors1 <[email protected]> * fix microbatch calculator Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: ashors1 <[email protected]>
ashors1
force-pushed
the
cherry-pick-main-f2a5426ff2b436ec09872f0cf1f93d6b966c9c78
branch
from
e23369f to
33c965e
Compare
ashors1
previously approved these changes
Aug 2, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
| dummy_trainer.fit(model, data) | ||
| strategy = _get_strategy() | ||
| tmp_path = strategy.broadcast(tmp_path) |
Check notice
Code scanning / CodeQL
Unused local variable Note test
| ckpt_load_directly_on_device=False, | ||
| ckpt_async_save=True, | ||
| ) | ||
| trainer = nl.Trainer( |
Check notice
Code scanning / CodeQL
Unused local variable Note test
Signed-off-by: ashors1 <[email protected]>
ashors1
previously approved these changes
Aug 2, 2024
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
ashors1
approved these changes
Aug 3, 2024
ashors1
deleted the
cherry-pick-main-f2a5426ff2b436ec09872f0cf1f93d6b966c9c78
branch
adityavavre
pushed a commit
to adityavavre/NeMo
that referenced
this pull request
Sep 15, 2024
* [NeMo-UX] Add distributed checkpointing unit tests (NVIDIA#9794) * add dist checkpointing tests Signed-off-by: ashors1 <[email protected]> * fix recursion bug Signed-off-by: ashors1 <[email protected]> * raise original AttributeError Signed-off-by: ashors1 <[email protected]> * dist checkpoint test fixes Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> * set async_save from strategy to make checkpoint_io more robust Signed-off-by: ashors1 <[email protected]> * update async save test Signed-off-by: ashors1 <[email protected]> * fixes Signed-off-by: ashors1 <[email protected]> * clean up and address comments Signed-off-by: ashors1 <[email protected]> * fix mock datamodule Signed-off-by: ashors1 <[email protected]> * fix qk layer scaling setting Signed-off-by: ashors1 <[email protected]> * fix microbatch calculator Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: ashors1 <[email protected]> * fix test Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> * remove unused imports Signed-off-by: ashors1 <[email protected]> --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: Anna Shors <[email protected]> Co-authored-by: ashors1 <[email protected]> Co-authored-by: ashors1 <[email protected]> Signed-off-by: adityavavre <[email protected]>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* [NeMo-UX] Add distributed checkpointing unit tests (#9794) * add dist checkpointing tests Signed-off-by: ashors1 <[email protected]> * fix recursion bug Signed-off-by: ashors1 <[email protected]> * raise original AttributeError Signed-off-by: ashors1 <[email protected]> * dist checkpoint test fixes Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> * set async_save from strategy to make checkpoint_io more robust Signed-off-by: ashors1 <[email protected]> * update async save test Signed-off-by: ashors1 <[email protected]> * fixes Signed-off-by: ashors1 <[email protected]> * clean up and address comments Signed-off-by: ashors1 <[email protected]> * fix mock datamodule Signed-off-by: ashors1 <[email protected]> * fix qk layer scaling setting Signed-off-by: ashors1 <[email protected]> * fix microbatch calculator Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: ashors1 <[email protected]> * fix test Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> * remove unused imports Signed-off-by: ashors1 <[email protected]> --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: Anna Shors <[email protected]> Co-authored-by: ashors1 <[email protected]> Co-authored-by: ashors1 <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* [NeMo-UX] Add distributed checkpointing unit tests (NVIDIA#9794) * add dist checkpointing tests Signed-off-by: ashors1 <[email protected]> * fix recursion bug Signed-off-by: ashors1 <[email protected]> * raise original AttributeError Signed-off-by: ashors1 <[email protected]> * dist checkpoint test fixes Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> * set async_save from strategy to make checkpoint_io more robust Signed-off-by: ashors1 <[email protected]> * update async save test Signed-off-by: ashors1 <[email protected]> * fixes Signed-off-by: ashors1 <[email protected]> * clean up and address comments Signed-off-by: ashors1 <[email protected]> * fix mock datamodule Signed-off-by: ashors1 <[email protected]> * fix qk layer scaling setting Signed-off-by: ashors1 <[email protected]> * fix microbatch calculator Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: ashors1 <[email protected]> * fix test Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> * remove unused imports Signed-off-by: ashors1 <[email protected]> --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: Anna Shors <[email protected]> Co-authored-by: ashors1 <[email protected]> Co-authored-by: ashors1 <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
* [NeMo-UX] Add distributed checkpointing unit tests (NVIDIA#9794) * add dist checkpointing tests Signed-off-by: ashors1 <[email protected]> * fix recursion bug Signed-off-by: ashors1 <[email protected]> * raise original AttributeError Signed-off-by: ashors1 <[email protected]> * dist checkpoint test fixes Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> * set async_save from strategy to make checkpoint_io more robust Signed-off-by: ashors1 <[email protected]> * update async save test Signed-off-by: ashors1 <[email protected]> * fixes Signed-off-by: ashors1 <[email protected]> * clean up and address comments Signed-off-by: ashors1 <[email protected]> * fix mock datamodule Signed-off-by: ashors1 <[email protected]> * fix qk layer scaling setting Signed-off-by: ashors1 <[email protected]> * fix microbatch calculator Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: ashors1 <[email protected]> * fix test Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> * remove unused imports Signed-off-by: ashors1 <[email protected]> --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: Anna Shors <[email protected]> Co-authored-by: ashors1 <[email protected]> Co-authored-by: ashors1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information