Adds a Knob for OnlineSampling by introducing 'global_sample_mapping' in the SFT config.yaml #9913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoumpa
requested changes
Jul 29, 2024
akoumpa
approved these changes
Jul 30, 2024
…ping. Signed-off-by: conver334 <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
conver334
force-pushed
the
dev/simiao_zhang/knob_onlinesampling
branch
from
07d6ff5 to
af0b145
Compare
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Jul 30, 2024
… in the SFT config.yaml (NVIDIA#9913) * Add 'global_sample_mapping' in config for turn on/off OnlineSampleMapping. Signed-off-by: conver334 <[email protected]> * black Signed-off-by: Alexandros Koumparoulis <[email protected]> --------- Signed-off-by: conver334 <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: Simiao Zhang <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: Boxiang Wang <[email protected]>
xuanzic
pushed a commit
to xuanzic/NeMo
that referenced
this pull request
Aug 1, 2024
… in the SFT config.yaml (NVIDIA#9913) * Add 'global_sample_mapping' in config for turn on/off OnlineSampleMapping. Signed-off-by: conver334 <[email protected]> * black Signed-off-by: Alexandros Koumparoulis <[email protected]> --------- Signed-off-by: conver334 <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: Simiao Zhang <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: Vivian Chen <[email protected]>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
… in the SFT config.yaml (#9913) * Add 'global_sample_mapping' in config for turn on/off OnlineSampleMapping. Signed-off-by: conver334 <[email protected]> * black Signed-off-by: Alexandros Koumparoulis <[email protected]> --------- Signed-off-by: conver334 <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: Simiao Zhang <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
… in the SFT config.yaml (NVIDIA#9913) * Add 'global_sample_mapping' in config for turn on/off OnlineSampleMapping. Signed-off-by: conver334 <[email protected]> * black Signed-off-by: Alexandros Koumparoulis <[email protected]> --------- Signed-off-by: conver334 <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: Simiao Zhang <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
… in the SFT config.yaml (NVIDIA#9913) * Add 'global_sample_mapping' in config for turn on/off OnlineSampleMapping. Signed-off-by: conver334 <[email protected]> * black Signed-off-by: Alexandros Koumparoulis <[email protected]> --------- Signed-off-by: conver334 <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: Simiao Zhang <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds a Knob for OnlineSampling by introducing a new parameter 'global_sample_mapping' in the SFT config YAML(default value is false).
The feature was proposed in this Nvbug. This will allow users to choose the data sample method that best suits their needs.
Collection: NeMo's NLP collection
Changelog
Usage
change 'global_sample_mapping' in megatron_gpt_finetuning_config.yaml
False (default): Use OnlineSampleMapping. Shuffle the dataset within each epoch.
True: Shuffle the replicated data all together.
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
@ericharper
Anyone in the community is free to review the PR once the checks have passed.
Additional Information
The second suggested Improvement has not been fixed yet