Akoumparouli/mixtral fixes for r2.0.0rc1 #9911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoumpa
force-pushed
the
akoumparouli/mixtral_fixes_for_r2.0.0rc1
branch
3 times, most recently
from
12ce03c to
209a241
Compare
akoumpa
force-pushed
the
akoumparouli/mixtral_fixes_for_r2.0.0rc1
branch
6 times, most recently
from
273f6b5 to
f4de842
Compare
…rect dtype Signed-off-by: Alexandros Koumparoulis <[email protected]>
… transforming ckpt Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: akoumpa <[email protected]>
akoumpa
force-pushed
the
akoumparouli/mixtral_fixes_for_r2.0.0rc1
branch
from
d221daa to
48ccf0a
Compare
akoumpa
requested review from
JRD971000 and
ashors1
and removed request for
JRD971000
ashors1
reviewed
Jul 26, 2024
| @@ -124,3 +124,6 @@ def _preprocess_and_split_data( | |||
| shutil.rmtree(p) | |||
| elif '.jsonl' not in str(p.name): | |||
| p.unlink() | |||
|
|
|||
| def reconfigure_limit_batches(self): | |||
There was a problem hiding this comment.
Can we remove this now that a fix has been merged?
|
Besides the minor comment above, LGTM |
ashors1
approved these changes
Jul 26, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
* nemo-ux-mixtral: use cpu init & skip init when importing; specify correct dtype Signed-off-by: Alexandros Koumparoulis <[email protected]> * nemo-ux-state: handle None in state_dict.keys; disable auto-grad when transforming ckpt Signed-off-by: Alexandros Koumparoulis <[email protected]> * add dummy SquadDataModule.reconfigure_limit_batches Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: akoumpa <[email protected]>
akoumpa
added a commit
that referenced
this pull request
Jul 29, 2024
* nemo-ux-mixtral: use cpu init & skip init when importing; specify correct dtype Signed-off-by: Alexandros Koumparoulis <[email protected]> * nemo-ux-state: handle None in state_dict.keys; disable auto-grad when transforming ckpt Signed-off-by: Alexandros Koumparoulis <[email protected]> * add dummy SquadDataModule.reconfigure_limit_batches Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: akoumpa <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]>
akoumpa
added a commit
that referenced
this pull request
Jul 30, 2024
* nemo-ux-mixtral: use cpu init & skip init when importing; specify correct dtype * nemo-ux-state: handle None in state_dict.keys; disable auto-grad when transforming ckpt * add dummy SquadDataModule.reconfigure_limit_batches * Apply isort and black reformatting --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: akoumpa <[email protected]>
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Jul 30, 2024
* nemo-ux-mixtral: use cpu init & skip init when importing; specify correct dtype * nemo-ux-state: handle None in state_dict.keys; disable auto-grad when transforming ckpt * add dummy SquadDataModule.reconfigure_limit_batches * Apply isort and black reformatting --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: akoumpa <[email protected]> Signed-off-by: Boxiang Wang <[email protected]>
xuanzic
pushed a commit
to xuanzic/NeMo
that referenced
this pull request
Aug 1, 2024
* nemo-ux-mixtral: use cpu init & skip init when importing; specify correct dtype * nemo-ux-state: handle None in state_dict.keys; disable auto-grad when transforming ckpt * add dummy SquadDataModule.reconfigure_limit_batches * Apply isort and black reformatting --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: akoumpa <[email protected]> Signed-off-by: Vivian Chen <[email protected]>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* nemo-ux-mixtral: use cpu init & skip init when importing; specify correct dtype * nemo-ux-state: handle None in state_dict.keys; disable auto-grad when transforming ckpt * add dummy SquadDataModule.reconfigure_limit_batches * Apply isort and black reformatting --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: akoumpa <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* nemo-ux-mixtral: use cpu init & skip init when importing; specify correct dtype * nemo-ux-state: handle None in state_dict.keys; disable auto-grad when transforming ckpt * add dummy SquadDataModule.reconfigure_limit_batches * Apply isort and black reformatting --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: akoumpa <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
* nemo-ux-mixtral: use cpu init & skip init when importing; specify correct dtype * nemo-ux-state: handle None in state_dict.keys; disable auto-grad when transforming ckpt * add dummy SquadDataModule.reconfigure_limit_batches * Apply isort and black reformatting --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: akoumpa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information