Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Jpg2p jun18 (#9538)" #9874

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

pablo-garay
Copy link
Collaborator

This reverts commit 53d7a91.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@pablo-garay pablo-garay merged commit 11bbe0b into main Jul 24, 2024
12 of 13 checks passed
@pablo-garay pablo-garay deleted the pagaray/revert_for_cicd_bugfix branch July 24, 2024 20:30
akoumpa pushed a commit that referenced this pull request Jul 25, 2024
* Revert "Jpg2p jun18 (#9538)"

This reverts commit 53d7a91.

* Apply isort and black reformatting

Signed-off-by: pablo-garay <[email protected]>

---------

Signed-off-by: pablo-garay <[email protected]>
Co-authored-by: pablo-garay <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@XuesongYang XuesongYang mentioned this pull request Jul 26, 2024
8 tasks
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jul 30, 2024
* Revert "Jpg2p jun18 (NVIDIA#9538)"

This reverts commit 53d7a91.

* Apply isort and black reformatting

Signed-off-by: pablo-garay <[email protected]>

---------

Signed-off-by: pablo-garay <[email protected]>
Co-authored-by: pablo-garay <[email protected]>
Signed-off-by: Boxiang Wang <[email protected]>
xuanzic pushed a commit to xuanzic/NeMo that referenced this pull request Aug 1, 2024
* Revert "Jpg2p jun18 (NVIDIA#9538)"

This reverts commit 53d7a91.

* Apply isort and black reformatting

Signed-off-by: pablo-garay <[email protected]>

---------

Signed-off-by: pablo-garay <[email protected]>
Co-authored-by: pablo-garay <[email protected]>
Signed-off-by: Vivian Chen <[email protected]>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* Revert "Jpg2p jun18 (#9538)"

This reverts commit 53d7a91.

* Apply isort and black reformatting

Signed-off-by: pablo-garay <[email protected]>

---------

Signed-off-by: pablo-garay <[email protected]>
Co-authored-by: pablo-garay <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* Revert "Jpg2p jun18 (NVIDIA#9538)"

This reverts commit 53d7a91.

* Apply isort and black reformatting

Signed-off-by: pablo-garay <[email protected]>

---------

Signed-off-by: pablo-garay <[email protected]>
Co-authored-by: pablo-garay <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
* Revert "Jpg2p jun18 (NVIDIA#9538)"

This reverts commit 53d7a91.

* Apply isort and black reformatting

Signed-off-by: pablo-garay <[email protected]>

---------

Signed-off-by: pablo-garay <[email protected]>
Co-authored-by: pablo-garay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant