Fixing canary prompts for back compatibility #9836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Travis Bartley <[email protected]>
Signed-off-by: tbartley94 <[email protected]>
pzelasko
reviewed
Jul 23, 2024
| @@ -173,7 +173,7 @@ def canary( | |||
| role="assistant", | |||
| slots={ | |||
| "text": ' '.join(s.text for s in cut.supervisions), | |||
| formatter.PROMPT_LANGUAGE_SLOT: cut.custom["target_lang"], | |||
| formatter.PROMPT_LANGUAGE_SLOT: cut.custom["lang"], | |||
There was a problem hiding this comment.
Right I missed this. Let’s use „cut.supervisions[0].language” which takes its value from either lang or target_lang depending on what was specified in lang_field
Signed-off-by: Travis Bartley <[email protected]>
Signed-off-by: tbartley94 <[email protected]>
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Jul 30, 2024
* Fixing canary prompts for back compatibility Signed-off-by: Travis Bartley <[email protected]> * Apply isort and black reformatting Signed-off-by: tbartley94 <[email protected]> * allows setting of lang field Signed-off-by: Travis Bartley <[email protected]> * Apply isort and black reformatting Signed-off-by: tbartley94 <[email protected]> --------- Signed-off-by: Travis Bartley <[email protected]> Signed-off-by: tbartley94 <[email protected]> Co-authored-by: tbartley94 <[email protected]> Signed-off-by: Boxiang Wang <[email protected]>
xuanzic
pushed a commit
to xuanzic/NeMo
that referenced
this pull request
Aug 1, 2024
* Fixing canary prompts for back compatibility Signed-off-by: Travis Bartley <[email protected]> * Apply isort and black reformatting Signed-off-by: tbartley94 <[email protected]> * allows setting of lang field Signed-off-by: Travis Bartley <[email protected]> * Apply isort and black reformatting Signed-off-by: tbartley94 <[email protected]> --------- Signed-off-by: Travis Bartley <[email protected]> Signed-off-by: tbartley94 <[email protected]> Co-authored-by: tbartley94 <[email protected]> Signed-off-by: Vivian Chen <[email protected]>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Fixing canary prompts for back compatibility Signed-off-by: Travis Bartley <[email protected]> * Apply isort and black reformatting Signed-off-by: tbartley94 <[email protected]> * allows setting of lang field Signed-off-by: Travis Bartley <[email protected]> * Apply isort and black reformatting Signed-off-by: tbartley94 <[email protected]> --------- Signed-off-by: Travis Bartley <[email protected]> Signed-off-by: tbartley94 <[email protected]> Co-authored-by: tbartley94 <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* Fixing canary prompts for back compatibility Signed-off-by: Travis Bartley <[email protected]> * Apply isort and black reformatting Signed-off-by: tbartley94 <[email protected]> * allows setting of lang field Signed-off-by: Travis Bartley <[email protected]> * Apply isort and black reformatting Signed-off-by: tbartley94 <[email protected]> --------- Signed-off-by: Travis Bartley <[email protected]> Signed-off-by: tbartley94 <[email protected]> Co-authored-by: tbartley94 <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
* Fixing canary prompts for back compatibility Signed-off-by: Travis Bartley <[email protected]> * Apply isort and black reformatting Signed-off-by: tbartley94 <[email protected]> * allows setting of lang field Signed-off-by: Travis Bartley <[email protected]> * Apply isort and black reformatting Signed-off-by: tbartley94 <[email protected]> --------- Signed-off-by: Travis Bartley <[email protected]> Signed-off-by: tbartley94 <[email protected]> Co-authored-by: tbartley94 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes Canary prompts for back compatibility
Collection: [Note which collection this PR will affect]
Changelog
target_langtolangin Canary prompt to allow compatibility with other NeMo manifests.GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information