[NeMo-UX] Add more NeMo Logger tests #9795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
hemildesai
reviewed
Jul 25, 2024
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
…into ashors/nemo-ux-logger-tests
hemildesai
approved these changes
Jul 26, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
* add some more NeMoLogger tests and fix explicit_log_dir in 2.0 Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> * update explicit_log_dir test Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> * remove reference to exp_manager Signed-off-by: ashors1 <[email protected]> * update checkpoint restore test Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> * update comment Signed-off-by: ashors1 <[email protected]> --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: Pablo Garay <[email protected]> Co-authored-by: ashors1 <[email protected]>
ashors1
added a commit
that referenced
this pull request
Aug 2, 2024
* add some more NeMoLogger tests and fix explicit_log_dir in 2.0 Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> * update explicit_log_dir test Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> * remove reference to exp_manager Signed-off-by: ashors1 <[email protected]> * update checkpoint restore test Signed-off-by: ashors1 <[email protected]> * Apply isort and black reformatting Signed-off-by: ashors1 <[email protected]> * update comment Signed-off-by: ashors1 <[email protected]> --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: Pablo Garay <[email protected]> Co-authored-by: ashors1 <[email protected]>
ashors1
added a commit
that referenced
this pull request
Aug 2, 2024
* add some more NeMoLogger tests and fix explicit_log_dir in 2.0 * Apply isort and black reformatting * update explicit_log_dir test * Apply isort and black reformatting * remove reference to exp_manager * update checkpoint restore test * Apply isort and black reformatting * update comment --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: Anna Shors <[email protected]> Co-authored-by: Pablo Garay <[email protected]> Co-authored-by: ashors1 <[email protected]>
adityavavre
pushed a commit
to adityavavre/NeMo
that referenced
this pull request
Sep 15, 2024
* add some more NeMoLogger tests and fix explicit_log_dir in 2.0 * Apply isort and black reformatting * update explicit_log_dir test * Apply isort and black reformatting * remove reference to exp_manager * update checkpoint restore test * Apply isort and black reformatting * update comment --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: Anna Shors <[email protected]> Co-authored-by: Pablo Garay <[email protected]> Co-authored-by: ashors1 <[email protected]> Signed-off-by: adityavavre <[email protected]>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* add some more NeMoLogger tests and fix explicit_log_dir in 2.0 * Apply isort and black reformatting * update explicit_log_dir test * Apply isort and black reformatting * remove reference to exp_manager * update checkpoint restore test * Apply isort and black reformatting * update comment --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: Anna Shors <[email protected]> Co-authored-by: Pablo Garay <[email protected]> Co-authored-by: ashors1 <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* add some more NeMoLogger tests and fix explicit_log_dir in 2.0 * Apply isort and black reformatting * update explicit_log_dir test * Apply isort and black reformatting * remove reference to exp_manager * update checkpoint restore test * Apply isort and black reformatting * update comment --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: Anna Shors <[email protected]> Co-authored-by: Pablo Garay <[email protected]> Co-authored-by: ashors1 <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
* add some more NeMoLogger tests and fix explicit_log_dir in 2.0 * Apply isort and black reformatting * update explicit_log_dir test * Apply isort and black reformatting * remove reference to exp_manager * update checkpoint restore test * Apply isort and black reformatting * update comment --------- Signed-off-by: ashors1 <[email protected]> Signed-off-by: ashors1 <[email protected]> Co-authored-by: Anna Shors <[email protected]> Co-authored-by: Pablo Garay <[email protected]> Co-authored-by: ashors1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information