Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix few issues and docs for neva and clip in r2.0.0rc1 #9681

Merged
merged 13 commits into from
Jul 19, 2024
Merged

Fix few issues and docs for neva and clip in r2.0.0rc1 #9681

merged 13 commits into from
Jul 19, 2024

Conversation

yaoyu-33
Copy link
Collaborator

What does this PR do ?

Fix few issues and docs for neva and clip in r2.0.0rc1

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

yaoyu-33 added 5 commits July 10, 2024 15:52
@yaoyu-33
Fix clip model
21e6f99 
Signed-off-by: yaoyu-33 <[email protected]>
@yaoyu-33
fix neva loading due to fp8 change
73e83d0 
Signed-off-by: yaoyu-33 <[email protected]>
@yaoyu-33
Fix CLIP comment issues
abac83c 
Signed-off-by: yaoyu-33 <[email protected]>
@yaoyu-33
update docs
faa5655 
Signed-off-by: yaoyu-33 <[email protected]>
@yaoyu-33
Fix neva tutorial
241f232 
Signed-off-by: yaoyu-33 <[email protected]>
@yaoyu-33 yaoyu-33 changed the base branch from main to r2.0.0rc1 July 10, 2024 22:56
@yaoyu-33
fix siglip few things
95f0cb3 
Signed-off-by: yaoyu-33 <[email protected]>
@yaoyu-33 yaoyu-33 removed the Run CICD label Jul 15, 2024
huvunvidia
huvunvidia reviewed Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@huvunvidia huvunvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments. Other than that the PR looks good to me.

tutorials/multimodal/NeVA Tutorial.ipynb Show resolved Hide resolved
tutorials/multimodal/NeVA Tutorial.ipynb Show resolved Hide resolved
@yaoyu-33
fix comments
45eee9c 
Signed-off-by: yaoyu-33 <[email protected]>
@huvunvidia
Copy link
Collaborator

LGTM. Thanks.

huvunvidia
huvunvidia approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@huvunvidia huvunvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ericharper ericharper merged commit 11f44e1 into r2.0.0rc1 Jul 19, 2024
11 checks passed
@ericharper ericharper deleted the yuya/r2.0.0rc1_fix branch July 19, 2024 18:02
github-actions bot pushed a commit that referenced this pull request Jul 19, 2024
@yaoyu-33 @web-flow
Fix few issues and docs for neva and clip in r2.0.0rc1 (#9681)
9f67abe 
* Fix clip model

Signed-off-by: yaoyu-33 <[email protected]>

* fix neva loading due to fp8 change

Signed-off-by: yaoyu-33 <[email protected]>

* Fix CLIP comment issues

Signed-off-by: yaoyu-33 <[email protected]>

* update docs

Signed-off-by: yaoyu-33 <[email protected]>

* Fix neva tutorial

Signed-off-by: yaoyu-33 <[email protected]>

* Apply isort and black reformatting

Signed-off-by: yaoyu-33 <[email protected]>

* fix siglip few things

Signed-off-by: yaoyu-33 <[email protected]>

* Apply isort and black reformatting

Signed-off-by: yaoyu-33 <[email protected]>

* Update convert_siglip_hf_to_nemo.py

Signed-off-by: Yu Yao <[email protected]>

* fix comments

Signed-off-by: yaoyu-33 <[email protected]>

---------

Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: Yu Yao <[email protected]>
Co-authored-by: yaoyu-33 <[email protected]>
yaoyu-33 added a commit that referenced this pull request Jul 23, 2024
@github-actions @yaoyu-33
Fix few issues and docs for neva and clip in r2.0.0rc1 (#9681) (#9808)
f83f974 
* Fix clip model



* fix neva loading due to fp8 change



* Fix CLIP comment issues



* update docs



* Fix neva tutorial



* Apply isort and black reformatting



* fix siglip few things



* Apply isort and black reformatting



* Update convert_siglip_hf_to_nemo.py



* fix comments



---------

Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: Yu Yao <[email protected]>
Co-authored-by: Yu Yao <[email protected]>
Co-authored-by: yaoyu-33 <[email protected]>
tonyjie pushed a commit to tonyjie/NeMo that referenced this pull request Jul 24, 2024
@github-actions @yaoyu-33 @tonyjie
Fix few issues and docs for neva and clip in r2.0.0rc1 (NVIDIA#9681) (N…
f94adbc 
…VIDIA#9808)

* Fix clip model



* fix neva loading due to fp8 change



* Fix CLIP comment issues



* update docs



* Fix neva tutorial



* Apply isort and black reformatting



* fix siglip few things



* Apply isort and black reformatting



* Update convert_siglip_hf_to_nemo.py



* fix comments



---------

Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: Yu Yao <[email protected]>
Co-authored-by: Yu Yao <[email protected]>
Co-authored-by: yaoyu-33 <[email protected]>
akoumpa pushed a commit that referenced this pull request Jul 25, 2024
@github-actions @yaoyu-33 @akoumpa
Fix few issues and docs for neva and clip in r2.0.0rc1 (#9681) (#9808)
2821f00 
* Fix clip model

* fix neva loading due to fp8 change

* Fix CLIP comment issues

* update docs

* Fix neva tutorial

* Apply isort and black reformatting

* fix siglip few things

* Apply isort and black reformatting

* Update convert_siglip_hf_to_nemo.py

* fix comments

---------

Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: Yu Yao <[email protected]>
Co-authored-by: Yu Yao <[email protected]>
Co-authored-by: yaoyu-33 <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jul 30, 2024
@github-actions @yaoyu-33 @BoxiangW
Fix few issues and docs for neva and clip in r2.0.0rc1 (NVIDIA#9681) (N…
0ad09aa 
…VIDIA#9808)

* Fix clip model

* fix neva loading due to fp8 change

* Fix CLIP comment issues

* update docs

* Fix neva tutorial

* Apply isort and black reformatting

* fix siglip few things

* Apply isort and black reformatting

* Update convert_siglip_hf_to_nemo.py

* fix comments

---------

Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: Yu Yao <[email protected]>
Co-authored-by: Yu Yao <[email protected]>
Co-authored-by: yaoyu-33 <[email protected]>
Signed-off-by: Boxiang Wang <[email protected]>
xuanzic pushed a commit to xuanzic/NeMo that referenced this pull request Aug 1, 2024
@github-actions @yaoyu-33
Fix few issues and docs for neva and clip in r2.0.0rc1 (NVIDIA#9681) (N…
21d1513 
…VIDIA#9808)

* Fix clip model

* fix neva loading due to fp8 change

* Fix CLIP comment issues

* update docs

* Fix neva tutorial

* Apply isort and black reformatting

* fix siglip few things

* Apply isort and black reformatting

* Update convert_siglip_hf_to_nemo.py

* fix comments

---------

Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: Yu Yao <[email protected]>
Co-authored-by: Yu Yao <[email protected]>
Co-authored-by: yaoyu-33 <[email protected]>
Signed-off-by: Vivian Chen <[email protected]>
kchike pushed a commit to kchike/NeMo that referenced this pull request Aug 8, 2024
@github-actions @yaoyu-33 @kchike
Fix few issues and docs for neva and clip in r2.0.0rc1 (NVIDIA#9681) (N…
38912e4 
…VIDIA#9808)

* Fix clip model

* fix neva loading due to fp8 change

* Fix CLIP comment issues

* update docs

* Fix neva tutorial

* Apply isort and black reformatting

* fix siglip few things

* Apply isort and black reformatting

* Update convert_siglip_hf_to_nemo.py

* fix comments

---------

Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: Yu Yao <[email protected]>
Co-authored-by: Yu Yao <[email protected]>
Co-authored-by: yaoyu-33 <[email protected]>
Signed-off-by: kchike <[email protected]>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
@github-actions @yaoyu-33 @monica-sekoyan
Fix few issues and docs for neva and clip in r2.0.0rc1 (#9681) (#9808)
91eacf0 
* Fix clip model



* fix neva loading due to fp8 change



* Fix CLIP comment issues



* update docs



* Fix neva tutorial



* Apply isort and black reformatting



* fix siglip few things



* Apply isort and black reformatting



* Update convert_siglip_hf_to_nemo.py



* fix comments



---------

Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: Yu Yao <[email protected]>
Co-authored-by: Yu Yao <[email protected]>
Co-authored-by: yaoyu-33 <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
@github-actions @yaoyu-33
Fix few issues and docs for neva and clip in r2.0.0rc1 (NVIDIA#9681) (N…
80f17bb 
…VIDIA#9808)

* Fix clip model



* fix neva loading due to fp8 change



* Fix CLIP comment issues



* update docs



* Fix neva tutorial



* Apply isort and black reformatting



* fix siglip few things



* Apply isort and black reformatting



* Update convert_siglip_hf_to_nemo.py



* fix comments



---------

Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: Yu Yao <[email protected]>
Co-authored-by: Yu Yao <[email protected]>
Co-authored-by: yaoyu-33 <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
@github-actions @yaoyu-33 @XuesongYang
Fix few issues and docs for neva and clip in r2.0.0rc1 (NVIDIA#9681) (N…
bd31061 
…VIDIA#9808)

* Fix clip model



* fix neva loading due to fp8 change



* Fix CLIP comment issues



* update docs



* Fix neva tutorial



* Apply isort and black reformatting



* fix siglip few things



* Apply isort and black reformatting



* Update convert_siglip_hf_to_nemo.py



* fix comments



---------

Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: Yu Yao <[email protected]>
Co-authored-by: Yu Yao <[email protected]>
Co-authored-by: yaoyu-33 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huvunvidia huvunvidia huvunvidia approved these changes

Assignees
No one assigned
Labels
Multi Modal Run CICD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaoyu-33 @huvunvidia @ericharper