-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canary Adapters tutorial #9670
Merged
Merged
Canary Adapters tutorial #9670
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1353779
Fix issue with prompt_defaults
titu1994 596ea69
Add core level support for grad map tracking
titu1994 e84424a
Add core level support for grad map tracking
titu1994 058a340
Apply isort and black reformatting
titu1994 620baa6
Add tutorial and update repr of formatters
titu1994 31d314d
Update docs
titu1994 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
# Copyright (c) 2024, NVIDIA CORPORATION. All rights reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import os | ||
Check notice Code scanning / CodeQL Unused import Note test
Import of 'os' is not used.
|
||
import tempfile | ||
Check notice Code scanning / CodeQL Unused import Note test
Import of 'tempfile' is not used.
|
||
|
||
import pytest | ||
import torch | ||
|
||
from nemo.core.classes.module import NeuralModule | ||
|
||
|
||
class TempModule(NeuralModule): | ||
|
||
def __init__(self): | ||
super().__init__() | ||
|
||
self.layer1 = torch.nn.Linear(10, 10, bias=False) | ||
self.layer2 = torch.nn.Linear(10, 10, bias=False) | ||
|
||
|
||
class TestNeuralModule: | ||
|
||
@pytest.mark.unit | ||
def test_num_weights(self): | ||
module = TempModule() | ||
assert module.num_weights == 200 | ||
|
||
@pytest.mark.unit | ||
def test_freeze(self): | ||
module = TempModule() | ||
module.freeze() | ||
for p in module.parameters(): | ||
assert not p.requires_grad | ||
|
||
@pytest.mark.unit | ||
def test_unfreeze(self): | ||
module = TempModule() | ||
module.freeze() | ||
module.unfreeze() | ||
for p in module.parameters(): | ||
assert p.requires_grad | ||
|
||
@pytest.mark.unit | ||
def test_as_frozen(self): | ||
module = TempModule() | ||
|
||
for p in module.parameters(): | ||
assert p.requires_grad | ||
|
||
with module.as_frozen(): | ||
for p in module.parameters(): | ||
assert not p.requires_grad | ||
|
||
for p in module.parameters(): | ||
assert p.requires_grad | ||
|
||
@pytest.mark.unit | ||
def test_partial_unfreeze(self): | ||
module = TempModule() | ||
|
||
for param in module.layer1.parameters(): | ||
param.requires_grad = False | ||
|
||
module.freeze() | ||
|
||
for param in module.layer1.parameters(): | ||
assert not param.requires_grad | ||
|
||
assert module._frozen_grad_map is not None | ||
assert len(module._frozen_grad_map) == 2 | ||
assert module._frozen_grad_map['layer1.weight'] is False | ||
|
||
module.unfreeze(partial=True) | ||
|
||
# layer1 should still be frozen due to partial unfreeze | ||
assert module.layer1.weight.requires_grad is False | ||
assert not hasattr(module, '_frozen_grad_map') |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the name
partial
: my understanding is that this is intended asonly_adapters=False
but you don't want to name it as such to maintain separation of concerns between adapter and freeze/unfreeze APIs. I think the current name is a bit confusing when read out of the context of this PR; maybe we could at least extend the doc to explain why/when you might want to use this option?