Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeMo performance feature documentation #9482

Merged
merged 10 commits into from
Jul 11, 2024
Merged

NeMo performance feature documentation #9482

merged 10 commits into from
Jul 11, 2024

Conversation

erhoo82
Copy link
Collaborator

@erhoo82 erhoo82 commented Jun 15, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

erhoo82 added 3 commits June 14, 2024 17:11
Signed-off-by: Sangkug Lym <[email protected]>
@github-actions github-actions bot added the NLP label Jun 15, 2024
erhoo82 added 4 commits June 14, 2024 18:58
Signed-off-by: Sangkug Lym <[email protected]>
Signed-off-by: Sangkug Lym <[email protected]>
Signed-off-by: Sangkug Lym <[email protected]>
@erhoo82 erhoo82 requested review from ntajbakhsh and yaoyu-33 June 16, 2024 18:36
docs/source/features/activation_recomputation.rst Outdated Show resolved Hide resolved
docs/source/features/mixed_precision.rst Outdated Show resolved Hide resolved
docs/source/features/mixed_precision.rst Outdated Show resolved Hide resolved
docs/source/features/parallelisms.rst Show resolved Hide resolved
docs/source/features/parallelisms.rst Show resolved Hide resolved
Signed-off-by: Sangkug Lym <[email protected]>
Signed-off-by: Sangkug Lym <[email protected]>
@erhoo82
Copy link
Collaborator Author

erhoo82 commented Jun 27, 2024

Thanks, @jgerh for the suggestions.
There seem to be too many rephrases. If the changes are mainly about rewording, can you push the changes to my branch?

@jgerh
Copy link
Collaborator

jgerh commented Jun 27, 2024

I appreciate the feedback. I can update my edits and focus on copyediting only, rather than rephrasing.

Copy link
Collaborator

@jgerh jgerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finished the review and provided minor copyedits of the content.

Signed-off-by: Sangkug Lym <[email protected]>
@yaoyu-33 yaoyu-33 merged commit 6f91dcc into NVIDIA:main Jul 11, 2024
200 of 201 checks passed
nikitaved pushed a commit to nikitaved/NeMo that referenced this pull request Jul 16, 2024
ertkonuk pushed a commit that referenced this pull request Jul 19, 2024
malay-nagda pushed a commit to malay-nagda/NeMo that referenced this pull request Jul 26, 2024
tonyjie pushed a commit to tonyjie/NeMo that referenced this pull request Aug 6, 2024
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants