Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added YAML parsing for UB/TP overlap configs #7931

Closed
wants to merge 5 commits into from

Conversation

sanandaraj5597
Copy link
Collaborator

What does this PR do ?

Added a YAML parsing for UB/TP overlap configurations.

Selvaraj Anandaraj and others added 3 commits October 11, 2023 14:51
Signed-off-by: Selvaraj Anandaraj <[email protected]>
@ericharper
Copy link
Collaborator

jenkins

@jbaczek
Copy link
Collaborator

jbaczek commented Nov 23, 2023

This PR aims to reverse changes from this PR: #7003
"Added a YAML parsing for UB/TP overlap configurations." doesn't describe the problem that you want to solve. Please be more verbose.
The #7003 removed module loading, opening file and parsing arguments from the model class. All of this is what hydra is for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants