Adding carry-over status and carry-over values to SGD model #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
…er_carryover Signed-off-by: Vahid Noroozi <[email protected]> # Conflicts: # docs/sources/source/nlp/dialogue_state_tracking.rst
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
Signed-off-by: Vahid Noroozi <[email protected]>
ekmb
requested changes
Jun 17, 2020
| self.noncategorical_slot_status[slot_idx] = STATUS_CARRY | ||
| else: | ||
| self.noncategorical_slot_status[slot_idx] = STATUS_ACTIVE | ||
|
|
There was a problem hiding this comment.
Please move self.noncategorical_slot_status[slot_idx] = STATUS_ACTIVE back directly after else, the change happens only when self._add_carry_status is True
Signed-off-by: Vahid Noroozi <[email protected]>
…y default. Signed-off-by: Vahid Noroozi <[email protected]>
…y default. Signed-off-by: Vahid Noroozi <[email protected]>
…y default. Signed-off-by: Vahid Noroozi <[email protected]>
ekmb
previously approved these changes
Jun 17, 2020
Signed-off-by: Vahid Noroozi <[email protected]>
ekmb
approved these changes
Jun 17, 2020
dcurran90
pushed a commit
to dcurran90/NeMo
that referenced
this pull request
Oct 15, 2024
* Use setuptools_scm to auto-generate version [setuptools_scm](https://github.com/pypa/setuptools_scm) is the de-facto standard to automate the version information of a Python project. It uses information from version control system like git to generate [PEP 440](https://peps.python.org/pep-0440/) version identifiers. The version number is generated on build time and included in source dist and Python wheels. It works with `pip install` from a local checkout or git checkout URL. For git repositories, the version from the last git tag in the history. If the current checkout is not in tag, setuptools_scm includes git tag revision and count since last tag in the version. This information is useful to debug development checkouts. Example: `cli-0.10.2.dev4+g724d895` means four commits (`dev4`) after release tag `v0.10.1` (sic!). The change also fixes a problem with PR NVIDIA#727. It added dynamic version without actually making the version dynamic. Also run tests whenever `pyproject.toml` or requirements are modified. Resolves: NVIDIA#268 Resolves: NVIDIA#736 Signed-off-by: Christian Heimes <[email protected]> Signed-off-by: Mark Sturdevant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.