Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade hydra and omegaconf #7243

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Upgrade hydra and omegaconf #7243

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc617f4
Upgrade hydra and omegaconf
athitten Aug 16, 2023
97103cb
Edit omegaconf version
athitten Aug 16, 2023
4a12ebe
Merge branch 'main' into athitten/upgrade_hydra_omegaconf
athitten Aug 17, 2023
6e89d45
Merge branch 'main' into athitten/upgrade_hydra_omegaconf
athitten Aug 18, 2023
7bf8c72
Merge branch 'main' into athitten/upgrade_hydra_omegaconf
athitten Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions requirements/requirements_lightning.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
hydra-core>=1.2.0,<1.3
omegaconf>=2.2,<2.3
hydra-core>1.3,<=1.3.2
omegaconf<=2.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised why this isn't

hydra-core>=1.3.2,<1.4
omegaconf>=2.2.3,<2.4

Motivation:

  • For Hydra: looks like the goal is to upgrade to 1.3, so best take at least the latest minor 1.3 release, but prevent upgrading to 1.4 which might contain breaking changes. It's unclear why we'd want only 1.3.1 or 1.3.2 (which is what this PR does).
  • For OmegaConf: take at least the latest minor 2.2 version, allow 2.3.x since there were no breaking changes in 2.3.0 compared to 2.2, but prevent upgrading to 2.4 which might contain breaking changes.

@titu1994 why these specific choices?

pytorch-lightning>=2.0
torchmetrics>=0.11.0
transformers>=4.0.1
Expand Down