-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.rst #7175
Update README.rst #7175
Conversation
Signed-off-by: fayejf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Besides these changes, I guess we have to update ones to display correct info in PyPi repository. For example, we may need to change below,
Make sense. Thanks for pointing out. Updating. |
Signed-off-by: fayejf <[email protected]>
Signed-off-by: fayejf <[email protected]>
Updated the pypi and this will be reflected when @ericharper build next release. I'm not familier with this part please let me know if I missed anything. Just wondering do we need to strctly limit user to use python3.10? such as updating here please review @XuesongYang @titu1994 @ericharper |
Probably best to update it to 3.10+ everywhere so that it gets tested more |
@@ -217,6 +217,7 @@ def finalize_options(self): | |||
'Programming Language :: Python :: 3', | |||
'Programming Language :: Python :: 3.8', | |||
'Programming Language :: Python :: 3.9', | |||
'Programming Language :: Python :: 3.10', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove 3.8 from the above ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
Signed-off-by: fayejf <[email protected]>
Please approve again. The reason I hesitate to update to 3.10+ everywhere is I doubt phuoc was testing with 3.10. It's better to ask him to QA test on 3.10 in next release in case anything breaks. |
@@ -215,8 +215,8 @@ def finalize_options(self): | |||
'License :: OSI Approved :: Apache Software License', | |||
# Supported python versions | |||
'Programming Language :: Python :: 3', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to keep this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. rotating to @titu1994 and @ericharper for a final walk through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
* Update README.rst Signed-off-by: fayejf <[email protected]> * Update setup.py Signed-off-by: fayejf <[email protected]> * Update pyproject.toml Signed-off-by: fayejf <[email protected]> * Update setup.py Signed-off-by: fayejf <[email protected]> --------- Signed-off-by: fayejf <[email protected]> Signed-off-by: dorotat <[email protected]>
* Update README.rst Signed-off-by: fayejf <[email protected]> * Update setup.py Signed-off-by: fayejf <[email protected]> * Update pyproject.toml Signed-off-by: fayejf <[email protected]> * Update setup.py Signed-off-by: fayejf <[email protected]> --------- Signed-off-by: fayejf <[email protected]>
What does this PR do ?
update readme regarding container version and python version
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information