Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy Manager and NLG modules for MultiWOZ #691

Merged
merged 39 commits into from
Jun 5, 2020
Merged

Conversation

ekmb
Copy link
Collaborator

@ekmb ekmb commented Jun 2, 2020

A rule-based policy manager and natural language generation modules added to complete the goal-oriented dialogue pipeline on MultiWOZ dataset.

The complete pipeline for Multiwoz looks like this:

User utterance => DST module (pre-trained TRADE) => rule-based PM => rule-based NLG => system reply
With the added example users can have a conversation with the system and analyze the results of each of the dialogue modules separately.

Signed-off-by: Evelina Bakhturina [email protected]

ekmb added 13 commits June 2, 2020 15:09
Signed-off-by: Evelina Bakhturina <[email protected]>
Signed-off-by: Evelina Bakhturina <[email protected]>
Signed-off-by: Evelina Bakhturina <[email protected]>
Signed-off-by: Evelina Bakhturina <[email protected]>
Signed-off-by: Evelina Bakhturina <[email protected]>
Signed-off-by: Evelina Bakhturina <[email protected]>
Signed-off-by: Evelina Bakhturina <[email protected]>
Signed-off-by: Evelina Bakhturina <[email protected]>
Signed-off-by: Evelina Bakhturina <[email protected]>
Signed-off-by: Evelina Bakhturina <[email protected]>
Signed-off-by: Evelina Bakhturina <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jun 2, 2020

This pull request introduces 23 alerts when merging a7b0ab5 into 78b6bef - view on LGTM.com

new alerts:

  • 15 for Unused import
  • 8 for Wrong name for an argument in a class instantiation

@ekmb ekmb force-pushed the pm_trade_port_refacto branch from a7b0ab5 to 12256c9 Compare June 2, 2020 22:09
@lgtm-com
Copy link

lgtm-com bot commented Jun 2, 2020

This pull request introduces 23 alerts when merging 12256c9 into 78b6bef - view on LGTM.com

new alerts:

  • 15 for Unused import
  • 8 for Wrong name for an argument in a class instantiation

Signed-off-by: Evelina Bakhturina <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jun 2, 2020

This pull request introduces 1 alert when merging 7964c7e into 78b6bef - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a class instantiation

ekmb added 3 commits June 2, 2020 16:03
Signed-off-by: Evelina Bakhturina <[email protected]>
Signed-off-by: Evelina Bakhturina <[email protected]>
Signed-off-by: Evelina Bakhturina <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jun 3, 2020

This pull request introduces 10 alerts when merging 307b942 into 1273d8f - view on LGTM.com

new alerts:

  • 7 for Variable defined multiple times
  • 2 for Unused import
  • 1 for Non-iterable used in for loop

Signed-off-by: Evelina Bakhturina <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jun 3, 2020

This pull request introduces 1 alert when merging b752fec into 1273d8f - view on LGTM.com

new alerts:

  • 1 for Non-iterable used in for loop

@tkornuta-nvidia tkornuta-nvidia self-requested a review June 3, 2020 22:39
…nabled utilization of relative paths

Signed-off-by: Tomasz Kornuta <[email protected]>
Signed-off-by: Tomasz Kornuta <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jun 3, 2020

This pull request introduces 1 alert when merging 800b771 into 9a1366c - view on LGTM.com

new alerts:

  • 1 for Non-iterable used in for loop

@lgtm-com
Copy link

lgtm-com bot commented Jun 4, 2020

This pull request introduces 1 alert when merging d913c65 into 1ae4aa9 - view on LGTM.com

new alerts:

  • 1 for Non-iterable used in for loop

@lgtm-com
Copy link

lgtm-com bot commented Jun 4, 2020

This pull request introduces 1 alert when merging 6f3980b into 1ae4aa9 - view on LGTM.com

new alerts:

  • 1 for Non-iterable used in for loop

@lgtm-com
Copy link

lgtm-com bot commented Jun 4, 2020

This pull request introduces 2 alerts when merging 0fc5372 into 1ae4aa9 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Non-iterable used in for loop

@lgtm-com
Copy link

lgtm-com bot commented Jun 4, 2020

This pull request introduces 2 alerts when merging 7b9a899 into 1273aff - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Non-iterable used in for loop

@lgtm-com
Copy link

lgtm-com bot commented Jun 5, 2020

This pull request introduces 1 alert when merging 9d97337 into e14590b - view on LGTM.com

new alerts:

  • 1 for Unused import

tkornuta-nvidia
tkornuta-nvidia previously approved these changes Jun 5, 2020
Copy link
Contributor

@tkornuta-nvidia tkornuta-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to go with the current types

TODO (out-of-scope of this PR):

  1. unit test for "neural tuple"
  2. refactoring and unification of EncoderRNN

Signed-off-by: nvidia <[email protected]>
@ekmb ekmb merged commit 92ee0dd into master Jun 5, 2020
@ekmb ekmb deleted the pm_trade_port_refacto branch June 5, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants