Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rapidfuzz instead of fuzzywuzzy #655

Merged
merged 1 commit into from
May 22, 2020
Merged

use rapidfuzz instead of fuzzywuzzy #655

merged 1 commit into from
May 22, 2020

Conversation

maxbachmann
Copy link
Contributor

@maxbachmann maxbachmann commented May 22, 2020

FuzzyWuzzy and python-Levenshtein are GPLv2 or later licensed which requires to license projects that use them to be GPL Licensed aswell.
For this reason this Pullrequest replaces FuzzyWuzzy with RapidFuzz (I am the author) which is implementing the same algorithms but is based on a old version of fuzzywuzzy that was MIT Licensed.
Rapidfuzz is:

  • Mit licensed so it can be used with the license used by this project
  • Is faster than FuzzyWuzzy

@ekmb
Copy link
Collaborator

ekmb commented May 22, 2020

@maxbachmann thank you for the PR.

@ekmb ekmb merged commit 3c87df1 into NVIDIA:master May 22, 2020
dcurran90 pushed a commit to dcurran90/NeMo that referenced this pull request Oct 15, 2024
Now supports a diff from a specific commit
(in addition to a branch or HEAD)

Fixes NVIDIA#654

Signed-off-by: Derek Higgins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants