Better NaN/inf loss handling for O0 (skip step across workers) #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jocelyn Huang <[email protected]>
Signed-off-by: Jocelyn Huang <[email protected]>
blisc
previously requested changes
May 15, 2020
Signed-off-by: Jocelyn Huang <[email protected]>
okuchaiev
approved these changes
May 16, 2020
dcurran90
pushed a commit
to dcurran90/NeMo
that referenced
this pull request
Oct 15, 2024
Signed-off-by: Maciej Szulik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions.pynow syncs across workers to check for NaN/inf loss. Terminates all workers ifstop_on_nan_lossis set, ignores it and lets apex deal with it if amp optimization level is O1 or higher, and skips the step across workers otherwise.Signed-off-by: Jocelyn Huang [email protected]