Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online audio augmentation notebook in ASR examples #605

Merged
merged 7 commits into from
May 7, 2020

Conversation

titu1994
Copy link
Collaborator

@titu1994 titu1994 commented May 2, 2020

Changelog

Addition

  • Example notebook which shows the different augmentations that are currently available, how to instantiate them and use them in the ASR data loaders.
  • Also show how to create custom augmentations and register them with NeMo

@titu1994 titu1994 requested a review from blisc May 2, 2020 01:22
@blisc
Copy link
Collaborator

blisc commented May 5, 2020

Can you add a small blurb under each section: White Noise Perturbation, Gain Perturbation, Shift Perturbation, and Noise Augmentation explaining what each perturbation does?

@titu1994
Copy link
Collaborator Author

titu1994 commented May 5, 2020

Yeah that would be a good idea to explain what the Perturbation does. Good point.

@titu1994 titu1994 force-pushed the augmentation_example branch from 8c56899 to 6f41314 Compare May 7, 2020 01:08
@titu1994
Copy link
Collaborator Author

titu1994 commented May 7, 2020

Rebased with master and added comments as to how the simpler augmentations work and what should be the effect heard by the listener for the above listed augmentations.

@blisc
Copy link
Collaborator

blisc commented May 7, 2020

Minor issue. Github and Colab shows your notebook like so:
White Noise perturbation is performed by the following steps : 1) Randomly sample the amplitude of the noise from a uniformly distributed range (defined in dB)
Can you change it so there is a line break, like so:

White Noise perturbation is performed by the following steps :
1) Randomly sample the amplitude of the noise from a uniformly distributed range (defined in dB)

@titu1994 titu1994 force-pushed the augmentation_example branch from 6f41314 to 53bbdf2 Compare May 7, 2020 20:10
@titu1994
Copy link
Collaborator Author

titu1994 commented May 7, 2020

Fixed by explicitly adding a <br> tag after those comments. Seems Jupyter lab processes the beginning of lists with new lines automatically, but github and colab dont.

@titu1994 titu1994 merged commit ceee044 into NVIDIA:master May 7, 2020
@titu1994 titu1994 deleted the augmentation_example branch May 7, 2020 23:31
@titu1994
Copy link
Collaborator Author

titu1994 commented May 7, 2020

Thanks for the review!

dcurran90 pushed a commit to dcurran90/NeMo that referenced this pull request Oct 15, 2024
* Converting scripts called by train to use click

Signed-off-by: Dan McPherson <[email protected]>

* Converting scripts called by convert to use click

Signed-off-by: Dan McPherson <[email protected]>

---------

Signed-off-by: Dan McPherson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants