Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tn doc 16 #5954

Merged
merged 6 commits into from
Feb 7, 2023
Merged

Tn doc 16 #5954

merged 6 commits into from
Feb 7, 2023

Conversation

yzhang123
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123 yzhang123 requested a review from ekmb February 7, 2023 19:31
@github-actions github-actions bot added the NLP label Feb 7, 2023
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
Copy link
Collaborator

@ekmb ekmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ekmb ekmb merged commit 7887128 into r1.16.0 Feb 7, 2023
@ekmb ekmb deleted the tn_doc_16 branch February 7, 2023 22:53
github-actions bot pushed a commit that referenced this pull request Feb 7, 2023
* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>

* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>

* fix links

Signed-off-by: Yang Zhang <[email protected]>

* fix spelling

Signed-off-by: Yang Zhang <[email protected]>

* add warning

Signed-off-by: Yang Zhang <[email protected]>

* add comment

Signed-off-by: Yang Zhang <[email protected]>

---------

Signed-off-by: Yang Zhang <[email protected]>
XuesongYang pushed a commit that referenced this pull request Feb 17, 2023
* Tn doc 16 (#5954)
* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>
ericharper pushed a commit that referenced this pull request Mar 9, 2023
* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>

* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>

* fix links

Signed-off-by: Yang Zhang <[email protected]>

* fix spelling

Signed-off-by: Yang Zhang <[email protected]>

* add warning

Signed-off-by: Yang Zhang <[email protected]>

* add comment

Signed-off-by: Yang Zhang <[email protected]>

---------

Signed-off-by: Yang Zhang <[email protected]>
ericharper added a commit that referenced this pull request Mar 9, 2023
* update branch

Signed-off-by: ericharper <[email protected]>

* Tn doc 16 (#5954)

* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>

* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>

* fix links

Signed-off-by: Yang Zhang <[email protected]>

* fix spelling

Signed-off-by: Yang Zhang <[email protected]>

* add warning

Signed-off-by: Yang Zhang <[email protected]>

* add comment

Signed-off-by: Yang Zhang <[email protected]>

---------

Signed-off-by: Yang Zhang <[email protected]>

* fix links, add missing file (#6044)

* fix link, add missing file

Signed-off-by: ekmb <[email protected]>

* fix primer notebook links

Signed-off-by: ekmb <[email protected]>

---------

Signed-off-by: ekmb <[email protected]>

* Davidm/cherrypick r1.16.0 (#6082)

* gpt fix

Signed-off-by: David Mosallanezhad <[email protected]>

* per-micro-batch input loader (#5635)

* per-micro-batch input loader

* per-micro-batch input loader

set arg default val

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* minor fix

* apply per-microbatch-loader to only GPT

* update docstring on micro-batch input loader

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixed the default arg val

* fix batch size to 1 at log stat registration

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update container for CI

Signed-off-by: ericharper <[email protected]>

* update container in jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update container for CI

Signed-off-by: ericharper <[email protected]>

fix merge conflict

* revert Jenkinsfile

* Revert "revert Jenkinsfile"

This reverts commit d23b775.

* Update nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py

Signed-off-by: Tim Moon <[email protected]>

* add GradScaler

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: ericharper <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ericharper <[email protected]>
Co-authored-by: Tim Moon <[email protected]>

* added PR#5995

Signed-off-by: David Mosallanezhad <[email protected]>

* Distributed Adam optimizer overlaps param all-gather with forward compute (#5684)

* Add distopt support for overlapping param all-gather with forward compute

Signed-off-by: Tim Moon <[email protected]>

* Update Apex commit

Signed-off-by: Tim Moon <[email protected]>

---------

Signed-off-by: Tim Moon <[email protected]>
Co-authored-by: Eric Harper <[email protected]>

* per-micro-batch input loader (#5635)

* per-micro-batch input loader

* per-micro-batch input loader

set arg default val

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* minor fix

* apply per-microbatch-loader to only GPT

* update docstring on micro-batch input loader

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixed the default arg val

* fix batch size to 1 at log stat registration

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update container for CI

Signed-off-by: ericharper <[email protected]>

* update container in jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update container for CI

Signed-off-by: ericharper <[email protected]>

fix merge conflict

* revert Jenkinsfile

* Revert "revert Jenkinsfile"

This reverts commit d23b775.

* Update nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py

Signed-off-by: Tim Moon <[email protected]>

* add GradScaler

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: ericharper <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ericharper <[email protected]>
Co-authored-by: Tim Moon <[email protected]>

* adding early stop callback to ptuning (#6028)

* patch to allow using tokenizers without additional_special_tokens_ids attribute

Signed-off-by: arendu <[email protected]>

* early stop callback for prompt/p tuning

Signed-off-by: arendu <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update

Signed-off-by: arendu <[email protected]>

* added exp manager config for early stop

Signed-off-by: arendu <[email protected]>

* pushed logic for creating early stopping inside exp manager

Signed-off-by: arendu <[email protected]>

* pushed logic for creating early stopping inside exp manager

Signed-off-by: arendu <[email protected]>

* minor updates and added dataclass check

Signed-off-by: arendu <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* more args

Signed-off-by: arendu <[email protected]>

* more args

Signed-off-by: arendu <[email protected]>

---------

Signed-off-by: arendu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: David Mosallanezhad <[email protected]>
Signed-off-by: ericharper <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: arendu <[email protected]>
Co-authored-by: David Mosallanezhad <[email protected]>
Co-authored-by: Sangkug Lym <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ericharper <[email protected]>
Co-authored-by: Tim Moon <[email protected]>
Co-authored-by: Adi Renduchintala <[email protected]>

* update branch for pynini install script (#6150)

Signed-off-by: ericharper <[email protected]>

* update branch

Signed-off-by: ericharper <[email protected]>

* revert

Signed-off-by: ericharper <[email protected]>

* resolve conflict

Signed-off-by: ericharper <[email protected]>

* revert file add

Signed-off-by: ericharper <[email protected]>

* revert import

Signed-off-by: ericharper <[email protected]>

* revert

Signed-off-by: ericharper <[email protected]>

---------

Signed-off-by: ericharper <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: ekmb <[email protected]>
Signed-off-by: David Mosallanezhad <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: arendu <[email protected]>
Co-authored-by: Yang Zhang <[email protected]>
Co-authored-by: Evelina <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David Mosallanezhad <[email protected]>
Co-authored-by: Sangkug Lym <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tim Moon <[email protected]>
Co-authored-by: Adi Renduchintala <[email protected]>
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* Tn doc 16 (NVIDIA#5954)
* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* update branch

Signed-off-by: ericharper <[email protected]>

* Tn doc 16 (NVIDIA#5954)

* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>

* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>

* fix links

Signed-off-by: Yang Zhang <[email protected]>

* fix spelling

Signed-off-by: Yang Zhang <[email protected]>

* add warning

Signed-off-by: Yang Zhang <[email protected]>

* add comment

Signed-off-by: Yang Zhang <[email protected]>

---------

Signed-off-by: Yang Zhang <[email protected]>

* fix links, add missing file (NVIDIA#6044)

* fix link, add missing file

Signed-off-by: ekmb <[email protected]>

* fix primer notebook links

Signed-off-by: ekmb <[email protected]>

---------

Signed-off-by: ekmb <[email protected]>

* Davidm/cherrypick r1.16.0 (NVIDIA#6082)

* gpt fix

Signed-off-by: David Mosallanezhad <[email protected]>

* per-micro-batch input loader (NVIDIA#5635)

* per-micro-batch input loader

* per-micro-batch input loader

set arg default val

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* minor fix

* apply per-microbatch-loader to only GPT

* update docstring on micro-batch input loader

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixed the default arg val

* fix batch size to 1 at log stat registration

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update container for CI

Signed-off-by: ericharper <[email protected]>

* update container in jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update container for CI

Signed-off-by: ericharper <[email protected]>

fix merge conflict

* revert Jenkinsfile

* Revert "revert Jenkinsfile"

This reverts commit d23b775.

* Update nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py

Signed-off-by: Tim Moon <[email protected]>

* add GradScaler

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: ericharper <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ericharper <[email protected]>
Co-authored-by: Tim Moon <[email protected]>

* added PR#5995

Signed-off-by: David Mosallanezhad <[email protected]>

* Distributed Adam optimizer overlaps param all-gather with forward compute (NVIDIA#5684)

* Add distopt support for overlapping param all-gather with forward compute

Signed-off-by: Tim Moon <[email protected]>

* Update Apex commit

Signed-off-by: Tim Moon <[email protected]>

---------

Signed-off-by: Tim Moon <[email protected]>
Co-authored-by: Eric Harper <[email protected]>

* per-micro-batch input loader (NVIDIA#5635)

* per-micro-batch input loader

* per-micro-batch input loader

set arg default val

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* minor fix

* apply per-microbatch-loader to only GPT

* update docstring on micro-batch input loader

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixed the default arg val

* fix batch size to 1 at log stat registration

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update container for CI

Signed-off-by: ericharper <[email protected]>

* update container in jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update container for CI

Signed-off-by: ericharper <[email protected]>

fix merge conflict

* revert Jenkinsfile

* Revert "revert Jenkinsfile"

This reverts commit d23b775.

* Update nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py

Signed-off-by: Tim Moon <[email protected]>

* add GradScaler

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: ericharper <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ericharper <[email protected]>
Co-authored-by: Tim Moon <[email protected]>

* adding early stop callback to ptuning (NVIDIA#6028)

* patch to allow using tokenizers without additional_special_tokens_ids attribute

Signed-off-by: arendu <[email protected]>

* early stop callback for prompt/p tuning

Signed-off-by: arendu <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update

Signed-off-by: arendu <[email protected]>

* added exp manager config for early stop

Signed-off-by: arendu <[email protected]>

* pushed logic for creating early stopping inside exp manager

Signed-off-by: arendu <[email protected]>

* pushed logic for creating early stopping inside exp manager

Signed-off-by: arendu <[email protected]>

* minor updates and added dataclass check

Signed-off-by: arendu <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* more args

Signed-off-by: arendu <[email protected]>

* more args

Signed-off-by: arendu <[email protected]>

---------

Signed-off-by: arendu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: David Mosallanezhad <[email protected]>
Signed-off-by: ericharper <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: arendu <[email protected]>
Co-authored-by: David Mosallanezhad <[email protected]>
Co-authored-by: Sangkug Lym <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ericharper <[email protected]>
Co-authored-by: Tim Moon <[email protected]>
Co-authored-by: Adi Renduchintala <[email protected]>

* update branch for pynini install script (NVIDIA#6150)

Signed-off-by: ericharper <[email protected]>

* update branch

Signed-off-by: ericharper <[email protected]>

* revert

Signed-off-by: ericharper <[email protected]>

* resolve conflict

Signed-off-by: ericharper <[email protected]>

* revert file add

Signed-off-by: ericharper <[email protected]>

* revert import

Signed-off-by: ericharper <[email protected]>

* revert

Signed-off-by: ericharper <[email protected]>

---------

Signed-off-by: ericharper <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: ekmb <[email protected]>
Signed-off-by: David Mosallanezhad <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: arendu <[email protected]>
Co-authored-by: Yang Zhang <[email protected]>
Co-authored-by: Evelina <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David Mosallanezhad <[email protected]>
Co-authored-by: Sangkug Lym <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tim Moon <[email protected]>
Co-authored-by: Adi Renduchintala <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
* Tn doc 16 (NVIDIA#5954)
* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
* update branch

Signed-off-by: ericharper <[email protected]>

* Tn doc 16 (NVIDIA#5954)

* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>

* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>

* fix links

Signed-off-by: Yang Zhang <[email protected]>

* fix spelling

Signed-off-by: Yang Zhang <[email protected]>

* add warning

Signed-off-by: Yang Zhang <[email protected]>

* add comment

Signed-off-by: Yang Zhang <[email protected]>

---------

Signed-off-by: Yang Zhang <[email protected]>

* fix links, add missing file (NVIDIA#6044)

* fix link, add missing file

Signed-off-by: ekmb <[email protected]>

* fix primer notebook links

Signed-off-by: ekmb <[email protected]>

---------

Signed-off-by: ekmb <[email protected]>

* Davidm/cherrypick r1.16.0 (NVIDIA#6082)

* gpt fix

Signed-off-by: David Mosallanezhad <[email protected]>

* per-micro-batch input loader (NVIDIA#5635)

* per-micro-batch input loader

* per-micro-batch input loader

set arg default val

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* minor fix

* apply per-microbatch-loader to only GPT

* update docstring on micro-batch input loader

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixed the default arg val

* fix batch size to 1 at log stat registration

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update container for CI

Signed-off-by: ericharper <[email protected]>

* update container in jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update container for CI

Signed-off-by: ericharper <[email protected]>

fix merge conflict

* revert Jenkinsfile

* Revert "revert Jenkinsfile"

This reverts commit d23b775.

* Update nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py

Signed-off-by: Tim Moon <[email protected]>

* add GradScaler

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: ericharper <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ericharper <[email protected]>
Co-authored-by: Tim Moon <[email protected]>

* added PR#5995

Signed-off-by: David Mosallanezhad <[email protected]>

* Distributed Adam optimizer overlaps param all-gather with forward compute (NVIDIA#5684)

* Add distopt support for overlapping param all-gather with forward compute

Signed-off-by: Tim Moon <[email protected]>

* Update Apex commit

Signed-off-by: Tim Moon <[email protected]>

---------

Signed-off-by: Tim Moon <[email protected]>
Co-authored-by: Eric Harper <[email protected]>

* per-micro-batch input loader (NVIDIA#5635)

* per-micro-batch input loader

* per-micro-batch input loader

set arg default val

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* minor fix

* apply per-microbatch-loader to only GPT

* update docstring on micro-batch input loader

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixed the default arg val

* fix batch size to 1 at log stat registration

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update container for CI

Signed-off-by: ericharper <[email protected]>

* update container in jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update container for CI

Signed-off-by: ericharper <[email protected]>

fix merge conflict

* revert Jenkinsfile

* Revert "revert Jenkinsfile"

This reverts commit d23b775.

* Update nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py

Signed-off-by: Tim Moon <[email protected]>

* add GradScaler

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: ericharper <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ericharper <[email protected]>
Co-authored-by: Tim Moon <[email protected]>

* adding early stop callback to ptuning (NVIDIA#6028)

* patch to allow using tokenizers without additional_special_tokens_ids attribute

Signed-off-by: arendu <[email protected]>

* early stop callback for prompt/p tuning

Signed-off-by: arendu <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update

Signed-off-by: arendu <[email protected]>

* added exp manager config for early stop

Signed-off-by: arendu <[email protected]>

* pushed logic for creating early stopping inside exp manager

Signed-off-by: arendu <[email protected]>

* pushed logic for creating early stopping inside exp manager

Signed-off-by: arendu <[email protected]>

* minor updates and added dataclass check

Signed-off-by: arendu <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* more args

Signed-off-by: arendu <[email protected]>

* more args

Signed-off-by: arendu <[email protected]>

---------

Signed-off-by: arendu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: David Mosallanezhad <[email protected]>
Signed-off-by: ericharper <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: arendu <[email protected]>
Co-authored-by: David Mosallanezhad <[email protected]>
Co-authored-by: Sangkug Lym <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ericharper <[email protected]>
Co-authored-by: Tim Moon <[email protected]>
Co-authored-by: Adi Renduchintala <[email protected]>

* update branch for pynini install script (NVIDIA#6150)

Signed-off-by: ericharper <[email protected]>

* update branch

Signed-off-by: ericharper <[email protected]>

* revert

Signed-off-by: ericharper <[email protected]>

* resolve conflict

Signed-off-by: ericharper <[email protected]>

* revert file add

Signed-off-by: ericharper <[email protected]>

* revert import

Signed-off-by: ericharper <[email protected]>

* revert

Signed-off-by: ericharper <[email protected]>

---------

Signed-off-by: ericharper <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: ekmb <[email protected]>
Signed-off-by: David Mosallanezhad <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: arendu <[email protected]>
Co-authored-by: Yang Zhang <[email protected]>
Co-authored-by: Evelina <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David Mosallanezhad <[email protected]>
Co-authored-by: Sangkug Lym <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tim Moon <[email protected]>
Co-authored-by: Adi Renduchintala <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants