Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upperbound the torchmetrics version #5537

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Upperbound the torchmetrics version #5537

merged 1 commit into from
Dec 1, 2022

Conversation

SeanNaren
Copy link
Collaborator

@SeanNaren SeanNaren commented Dec 1, 2022

What does this PR do ?

Fixes current failures around torchmetrics new release.

Collection: [Note which collection this PR will affect]

Changelog

  • Upper bound torchmetrics version.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@SeanNaren SeanNaren merged commit 8497126 into main Dec 1, 2022
@SeanNaren SeanNaren deleted the fix/upperbound_torch branch December 1, 2022 21:12
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Dec 5, 2022
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Dec 5, 2022
andrusenkoau pushed a commit to andrusenkoau/NeMo that referenced this pull request Jan 5, 2023
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants