Disable sync_batch_comm in validation_step for GPT #5429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* disable sync_batch_comm in validation_step Signed-off-by: ericharper <[email protected]> * Read sync_batch_comm from config or default to False Signed-off-by: Markel Sanz Ausin <[email protected]> * Update megatron_gpt_config to default sync_batch_comm to False to avoid CUDA error Signed-off-by: Markel Sanz Ausin <[email protected]> * Empty Signed-off-by: MaximumEntropy <[email protected]> * Comment out test Signed-off-by: MaximumEntropy <[email protected]> Signed-off-by: ericharper <[email protected]> Signed-off-by: Markel Sanz Ausin <[email protected]> Signed-off-by: MaximumEntropy <[email protected]> Signed-off-by: Oleksii Kuchaiev <[email protected]> Co-authored-by: Oleksii Kuchaiev <[email protected]> Co-authored-by: Markel Sanz Ausin <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: Oleksii Kuchaiev <[email protected]>
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
ericharper
approved these changes
Dec 2, 2022
ericharper
deleted the
cherry-pick-main-01cd8b6b46dd75a0881258647aa66b65a9945fd5
branch
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Dec 5, 2022
…DIA#5429) * disable sync_batch_comm in validation_step Signed-off-by: ericharper <[email protected]> * Read sync_batch_comm from config or default to False Signed-off-by: Markel Sanz Ausin <[email protected]> * Update megatron_gpt_config to default sync_batch_comm to False to avoid CUDA error Signed-off-by: Markel Sanz Ausin <[email protected]> * Empty Signed-off-by: MaximumEntropy <[email protected]> * Comment out test Signed-off-by: MaximumEntropy <[email protected]> Signed-off-by: ericharper <[email protected]> Signed-off-by: Markel Sanz Ausin <[email protected]> Signed-off-by: MaximumEntropy <[email protected]> Signed-off-by: Oleksii Kuchaiev <[email protected]> Co-authored-by: Oleksii Kuchaiev <[email protected]> Co-authored-by: Markel Sanz Ausin <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: Oleksii Kuchaiev <[email protected]> Signed-off-by: ericharper <[email protected]> Signed-off-by: Markel Sanz Ausin <[email protected]> Signed-off-by: MaximumEntropy <[email protected]> Signed-off-by: Oleksii Kuchaiev <[email protected]> Co-authored-by: Eric Harper <[email protected]> Co-authored-by: Oleksii Kuchaiev <[email protected]> Co-authored-by: Markel Sanz Ausin <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: Oleksii Kuchaiev <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
andrusenkoau
pushed a commit
to andrusenkoau/NeMo
that referenced
this pull request
Jan 5, 2023
…DIA#5429) * disable sync_batch_comm in validation_step Signed-off-by: ericharper <[email protected]> * Read sync_batch_comm from config or default to False Signed-off-by: Markel Sanz Ausin <[email protected]> * Update megatron_gpt_config to default sync_batch_comm to False to avoid CUDA error Signed-off-by: Markel Sanz Ausin <[email protected]> * Empty Signed-off-by: MaximumEntropy <[email protected]> * Comment out test Signed-off-by: MaximumEntropy <[email protected]> Signed-off-by: ericharper <[email protected]> Signed-off-by: Markel Sanz Ausin <[email protected]> Signed-off-by: MaximumEntropy <[email protected]> Signed-off-by: Oleksii Kuchaiev <[email protected]> Co-authored-by: Oleksii Kuchaiev <[email protected]> Co-authored-by: Markel Sanz Ausin <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: Oleksii Kuchaiev <[email protected]> Signed-off-by: ericharper <[email protected]> Signed-off-by: Markel Sanz Ausin <[email protected]> Signed-off-by: MaximumEntropy <[email protected]> Signed-off-by: Oleksii Kuchaiev <[email protected]> Co-authored-by: Eric Harper <[email protected]> Co-authored-by: Oleksii Kuchaiev <[email protected]> Co-authored-by: Markel Sanz Ausin <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: Oleksii Kuchaiev <[email protected]> Signed-off-by: andrusenkoau <[email protected]>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
…DIA#5429) * disable sync_batch_comm in validation_step Signed-off-by: ericharper <[email protected]> * Read sync_batch_comm from config or default to False Signed-off-by: Markel Sanz Ausin <[email protected]> * Update megatron_gpt_config to default sync_batch_comm to False to avoid CUDA error Signed-off-by: Markel Sanz Ausin <[email protected]> * Empty Signed-off-by: MaximumEntropy <[email protected]> * Comment out test Signed-off-by: MaximumEntropy <[email protected]> Signed-off-by: ericharper <[email protected]> Signed-off-by: Markel Sanz Ausin <[email protected]> Signed-off-by: MaximumEntropy <[email protected]> Signed-off-by: Oleksii Kuchaiev <[email protected]> Co-authored-by: Oleksii Kuchaiev <[email protected]> Co-authored-by: Markel Sanz Ausin <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: Oleksii Kuchaiev <[email protected]> Signed-off-by: ericharper <[email protected]> Signed-off-by: Markel Sanz Ausin <[email protected]> Signed-off-by: MaximumEntropy <[email protected]> Signed-off-by: Oleksii Kuchaiev <[email protected]> Co-authored-by: Eric Harper <[email protected]> Co-authored-by: Oleksii Kuchaiev <[email protected]> Co-authored-by: Markel Sanz Ausin <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: Oleksii Kuchaiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
With sync_batch_comm=True in validation step we sometimes get CUDA errors while running validation.
Collection: NLP
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information