Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TTS] replace pitch normalization params with ??? #5392

Merged
merged 3 commits into from
Nov 14, 2022
Merged

[TTS] replace pitch normalization params with ??? #5392

merged 3 commits into from
Nov 14, 2022

Conversation

XuesongYang
Copy link
Collaborator

Signed-off-by: Xuesong Yang [email protected]

What does this PR do ?

Follow up the discussion in #5383, we decided to replace pitch norm params with ??? for all YAML configs just in case users forget to update with dataset-specific values.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@XuesongYang XuesongYang force-pushed the empty-default-pitch-norm branch from 0a48f6d to f76276c Compare November 10, 2022 20:53
redoctopus
redoctopus reviewed Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@redoctopus redoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this up, English configs look good. Will wait for @rlangman's word on the Spanish values for approval.

rlangman
rlangman previously approved these changes Nov 10, 2022
View reviewed changes
@XuesongYang
Copy link
Collaborator Author

XuesongYang commented Nov 10, 2022 •
edited
Loading

Our CI failed due to lack of pitch_mean: omegaconf.errors.InterpolationToMissingValueError: MissingMandatoryValue while resolving interpolation: Missing mandatory value: pitch_mean
. Details in http://10.110.40.131:8080/blue/rest/organizations/jenkins/pipelines/NeMo/branches/PR-5392/runs/3/nodes/1233/log/?start=0.

@redoctopus is it ok if I override pitch mean and std with LJSpeech's values for our CI tests on an4?

@redoctopus
Copy link
Collaborator

Our CI failed due to lack of pitch_mean: omegaconf.errors.InterpolationToMissingValueError: MissingMandatoryValue while resolving interpolation: Missing mandatory value: pitch_mean . Details in http://10.110.40.131:8080/blue/rest/organizations/jenkins/pipelines/NeMo/branches/PR-5392/runs/3/nodes/1233/log/?start=0.

Ugh, haha, I think we might be seeing this pop up occasionally for the next while.

@redoctopus is it ok if I override pitch mean and std with LJSpeech's values for our CI tests on an4?

Sure thing! Not super important for the test that the pitch mean/std is accurate to the toy dataset :P

@XuesongYang XuesongYang force-pushed the empty-default-pitch-norm branch from 77f0cf8 to 30ecbbd Compare November 11, 2022 00:11
redoctopus
redoctopus approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@redoctopus redoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@XuesongYang XuesongYang merged commit 3f2c1ae into main Nov 14, 2022
@XuesongYang XuesongYang deleted the empty-default-pitch-norm branch November 14, 2022 19:50
@redoctopus redoctopus mentioned this pull request Nov 14, 2022
Merged
8 tasks
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
@XuesongYang
[TTS] replace pitch normalization params with ??? (NVIDIA#5392)
dc5a1f9 
* replace pitch normalization params with ???
* add pitch mean and std overrides in CI

Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
@XuesongYang
[TTS] replace pitch normalization params with ??? (NVIDIA#5392)
3a6570e 
* replace pitch normalization params with ???
* add pitch mean and std overrides in CI

Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
JimmyZhang12 pushed a commit to JimmyZhang12/NeMo that referenced this pull request Dec 14, 2022
@XuesongYang
[TTS] replace pitch normalization params with ??? (NVIDIA#5392)
993f730 
* replace pitch normalization params with ???
* add pitch mean and std overrides in CI

Signed-off-by: Xuesong Yang <[email protected]>
andrusenkoau pushed a commit to andrusenkoau/NeMo that referenced this pull request Jan 5, 2023
@XuesongYang @andrusenkoau
[TTS] replace pitch normalization params with ??? (NVIDIA#5392)
ba47907 
* replace pitch normalization params with ???
* add pitch mean and std overrides in CI

Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: andrusenkoau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redoctopus redoctopus redoctopus approved these changes

@rlangman rlangman Awaiting requested review from rlangman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuesongYang @redoctopus @rlangman