Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS] add CI test for RADTTS training recipe. #5386

Closed
wants to merge 1 commit into from
Closed

Conversation

XuesongYang
Copy link
Collaborator

Signed-off-by: Xuesong Yang [email protected]

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@lgtm-com
Copy link

lgtm-com bot commented Nov 10, 2022

This pull request introduces 2 alerts when merging c869c2e into d4ce66d - view on LGTM.com

new alerts:

  • 2 for Unused import

Copy link
Collaborator

@borisfom borisfom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated my branch ... a lot, please pick up - or should we merge mine first ?

@XuesongYang
Copy link
Collaborator Author

I have updated my branch ... a lot, please pick up - or should we merge mine first ?

This is a draft PR in order to test radtts. Since it is contingent on your fix, do you mind if cherry-pick this one to your PR? I will let you know once I cleaned up this PR. Thanks.

@XuesongYang
Copy link
Collaborator Author

close this PR since #5358 has cherry-picked these changes.

@XuesongYang XuesongYang deleted the add-CI-radtts branch November 17, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants