Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nvfuser for gpt #3845

Merged
merged 4 commits into from
Mar 16, 2022
Merged

Disable nvfuser for gpt #3845

merged 4 commits into from
Mar 16, 2022

Conversation

ericharper
Copy link
Collaborator

What does this PR do ?

Disables NVFUSER and gets global batch size from config in build dataset

Collection: NLP

Changelog

  • Comment out call that enables nvfuser in ngc container
  • Get global batch size from config

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: ericharper <[email protected]>
Signed-off-by: ericharper <[email protected]>
Signed-off-by: ericharper <[email protected]>
Copy link
Contributor

@MaximumEntropy MaximumEntropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericharper ericharper merged commit 8c80f1b into main Mar 16, 2022
@ericharper ericharper deleted the disable_nvfuser_gpt branch March 16, 2022 16:29
fayejf pushed a commit that referenced this pull request Mar 22, 2022
* disable nvfuser

Signed-off-by: ericharper <[email protected]>

* disable nvfuser

Signed-off-by: ericharper <[email protected]>

* delete line

Signed-off-by: ericharper <[email protected]>
fayejf pushed a commit that referenced this pull request Mar 22, 2022
* disable nvfuser

Signed-off-by: ericharper <[email protected]>

* disable nvfuser

Signed-off-by: ericharper <[email protected]>

* delete line

Signed-off-by: ericharper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants