Fixed Apex guard when imported classes are used for default values #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Apex class is missing. 2. Fixed Apex guard. Signed-off-by: Micha Livne <[email protected]>
Signed-off-by: Micha Livne <[email protected]>
Signed-off-by: Micha Livne <[email protected]>
…e/NeMo into bug-fix-apex-guard-transformer
Signed-off-by: Micha Livne <[email protected]>
ericharper
previously approved these changes
Feb 17, 2022
Signed-off-by: Micha Livne <[email protected]>
fayejf
pushed a commit
that referenced
this pull request
Mar 2, 2022
…3700) * 1. Added ApexGuardDefaults class that provides None attributes when an Apex class is missing. 2. Fixed Apex guard. Signed-off-by: Micha Livne <[email protected]> * 1. Fixed style. Signed-off-by: Micha Livne <[email protected]> * 1.Added more guard. Signed-off-by: Micha Livne <[email protected]> * 1. Fixed style. Signed-off-by: Micha Livne <[email protected]> * 1. Added another guard. Signed-off-by: Micha Livne <[email protected]> Co-authored-by: Micha Livne <[email protected]> Co-authored-by: Eric Harper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Micha Livne [email protected]
What does this PR do ?
This PR fixes an Apex guard that leaves constructors with undefined constructor values.
Collection: [Note which collection this PR will affect]
Changelog
ApexGuardDefaultsclass tonemo/collections/nlp/modules/common/megatron/utils.pyApexGuardDefaultsto replace missing classes innemo/collections/nlp/modules/common/megatron/transformer.py