Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out numba in 22.01 release #3685

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Conversation

titu1994
Copy link
Collaborator

Signed-off-by: smajumdar [email protected]

What does this PR do ?

Comment out numba install in 22.01 release. It contains numba 0.53.1 which works with RNNT.

Collection: [ASR]

Changelog

  • Comment out numba due to numpy conflict.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@titu1994 titu1994 requested a review from ericharper February 16, 2022 01:10
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ericharper ericharper merged commit b5012d0 into NVIDIA:main Feb 16, 2022
@titu1994 titu1994 deleted the upde_numba branch February 16, 2022 01:11
fayejf pushed a commit that referenced this pull request Mar 2, 2022
Signed-off-by: smajumdar <[email protected]>

Co-authored-by: Eric Harper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants