Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compression from .nemo files #3626

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Remove compression from .nemo files #3626

merged 4 commits into from
Feb 8, 2022

Conversation

okuchaiev
Copy link
Member

What does this PR do ?

This PR removes compression from .nemo files.
The compression is not desirable because:

  • It takes awfully long to compress multi-billion parameter language models
  • It does not actually save much space. For example a large CTC conformer uncompressed is 464Mb vs 431Mb compressed

This is a change to core save_to/restore_from functionality of all models.
It is backwards compatible - older checkpoints (with compression) will still work

Usage

  • Usage remains exactly the same.

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@okuchaiev
Remove compression from .nemo files
c0bcba6 
Signed-off-by: Oleksii Kuchaiev <[email protected]>
titu1994
titu1994 approved these changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but it will have downstream effect. The try catch check will also waste a few seconds for large Conformers but that is unavoidable

ericharper
ericharper approved these changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit c3101cc into main Feb 8, 2022
@ericharper ericharper deleted the restore_update branch February 8, 2022 17:16
fayejf pushed a commit that referenced this pull request Mar 2, 2022
@okuchaiev @titu1994
@ericharper @fayejf
Remove compression from .nemo files (#3626)
45355e9 
Signed-off-by: Oleksii Kuchaiev <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharper ericharper ericharper approved these changes

@titu1994 titu1994 titu1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@okuchaiev @titu1994 @ericharper