Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS] Fix UnivNet LibriTTS pretrained location #3615

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Conversation

m-toman
Copy link
Contributor

@m-toman m-toman commented Feb 6, 2022

What does this PR do ?

Mini-PR :) - Fixes the NGC location of the UnivNet LibriTTS pretrained model.

Collection: TTS

Changelog

  • Fixes the NGC location of the UnivNet LibriTTS pretrained model.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@Oktai15
Copy link
Contributor

Oktai15 commented Feb 7, 2022

Could you sign your commits according to the dco bot?

@m-toman
Copy link
Contributor Author

m-toman commented Feb 7, 2022

Wonder my -S shows me a verified but when submitting the PR it still complains. Perhaps it's the automatic merge that's the issue.
Just did rebase/amend.
If it still fails probably easier if you just fix the URI before we waste more time with that PR ;)

@m-toman
Copy link
Contributor Author

m-toman commented Feb 7, 2022

Actually just noticed the dco bot is fine now, just CI still complaining.

Signed-off-by: Markus Toman <[email protected]>
@Oktai15 Oktai15 merged commit 66ac0b3 into NVIDIA:main Feb 8, 2022
@Oktai15 Oktai15 changed the title Fix UnivNet LibriTTS pretrained location [TTS] Fix UnivNet LibriTTS pretrained location Feb 8, 2022
fayejf pushed a commit that referenced this pull request Mar 2, 2022
Signed-off-by: Markus Toman <[email protected]>

Co-authored-by: Oktai Tatanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants