Fixed EH and error reporting in restore_from

[borisfom]

Signed-off-by: Boris Fomitchev [email protected]

What does this PR do ?

Fixes 'lost cascading error info' due to constructor not being under try:.
As a result, my previously added code to save initial error was not executed.
Also streamlined control flow in that block.

Collection: [Note which collection this PR will affect]

Changelog

• Add specific line by line info of high level changes in this PR.

Usage

• You can potentially add a usage example below

# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

• Make sure you read and followed Contributor guidelines
• Did you write any new necessary tests?
• Did you add or update any necessary documentation?
• Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

• New Feature
• Bugfix
• Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

• Related to # (issue)

[borisfom]

Well, I realized the actual problem was fixed in main right before ... so that fix only streamlines flow and improves formatting.

[titu1994]

The other changes look great

[ericharper]

LGTM. Thanks!

[titu1994]

Lgtm