-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pr template and re-add Changelog builder #3575
Changes from 9 commits
77c3bd0
82f134e
4f62cea
dc6e104
b428c34
646ed49
51ce4e1
e66ff1b
379c9b1
007d141
090ab97
ae09fb0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,26 @@ | ||
# What does this PR do? | ||
**Collection**: [Note which collection this PR will affect] | ||
|
||
Please have one of the following: | ||
# Changelog | ||
- Add specific line by line info of high level changes in this PR. | ||
|
||
* Fixes # (issue) | ||
* New feature: (short feature description) | ||
# Usage | ||
* You can potentially add a usage example below | ||
|
||
## Before your PR is "Ready for review" | ||
```python | ||
# Add a code snippet demonstrating how to use this | ||
``` | ||
|
||
# Before your PR is "Ready for review" | ||
**Pre checks**: | ||
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) | ||
- [ ] Did you write any new necessary tests? | ||
- [ ] Did you add or updated any necessary documentation? | ||
|
||
- [ ] Did you add or update any necessary documentation? | ||
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) | ||
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries? | ||
|
||
**PR Type**: | ||
- [ ] Bugfix | ||
- [ ] Documentation | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New feature is the default and would almost always be selected though ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added it. |
||
|
||
If you haven't finished some of the above items you can still open "Draft" PR. | ||
|
||
|
@@ -18,3 +29,6 @@ If you haven't finished some of the above items you can still open "Draft" PR. | |
|
||
Anyone in the community is free to review the PR once the checks have passed. | ||
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. | ||
|
||
# Additional Information | ||
* Related to # (issue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need a header here, or people are going to miss filling out the collection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a header.