Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix, need to freeze the model #3540

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Bugfix, need to freeze the model #3540

merged 3 commits into from
Jan 28, 2022

Conversation

yidong72
Copy link
Collaborator

The model needs to be in the eval mode by calling freeze so the dropout performs correctly.

@yidong72 yidong72 requested a review from ericharper January 27, 2022 20:57
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit 8b2d27a into main Jan 28, 2022
@ericharper ericharper deleted the bug_ptune_model_eval branch January 28, 2022 01:38
nithinraok pushed a commit that referenced this pull request Feb 2, 2022
Signed-off-by: Yi Dong <[email protected]>

Co-authored-by: Eric Harper <[email protected]>
fayejf pushed a commit that referenced this pull request Mar 2, 2022
Signed-off-by: Yi Dong <[email protected]>

Co-authored-by: Eric Harper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants