Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code format checkers #286

Merged
merged 8 commits into from
Jan 25, 2020
Merged

Code format checkers #286

merged 8 commits into from
Jan 25, 2020

Conversation

stasbel
Copy link
Contributor

@stasbel stasbel commented Jan 23, 2020

>>> python setup.py check_style
running check_style
Running command: isort --multi-line=3 --trailing-comma --force-grid-wrap=0 --use-parentheses --line-width=119 -rc . --check --diff
Skipped 2 files
Running command: black --skip-string-normalization --line-length=119 . --check --diff
All done! ✨ 🍰 ✨
206 files would be left unchanged.
PASS
>>> python setup.py fix_style
running fix_style
Running command: isort --multi-line=3 --trailing-comma --force-grid-wrap=0 --use-parentheses --line-width=119 -rc .
Skipped 2 files
Running command: black --skip-string-normalization --line-length=119 .
All done! ✨ 🍰 ✨
206 files left unchanged.

@stasbel stasbel requested a review from blisc January 23, 2020 00:47
@lgtm-com
Copy link

lgtm-com bot commented Jan 23, 2020

This pull request introduces 16 alerts and fixes 16 when merging caddc35 into b986859 - view on LGTM.com

new alerts:

  • 10 for Unused import
  • 4 for Module is imported with 'import' and 'import from'
  • 2 for 'import *' may pollute namespace

fixed alerts:

  • 10 for Unused import
  • 4 for Module is imported with 'import' and 'import from'
  • 2 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Jan 23, 2020

This pull request introduces 15 alerts and fixes 15 when merging 1404b38 into b986859 - view on LGTM.com

new alerts:

  • 9 for Unused import
  • 4 for Module is imported with 'import' and 'import from'
  • 2 for 'import *' may pollute namespace

fixed alerts:

  • 9 for Unused import
  • 4 for Module is imported with 'import' and 'import from'
  • 2 for 'import *' may pollute namespace

@stasbel stasbel removed the request for review from blisc January 23, 2020 06:51
@lgtm-com
Copy link

lgtm-com bot commented Jan 23, 2020

This pull request introduces 12 alerts and fixes 27 when merging 492f7da into b986859 - view on LGTM.com

new alerts:

  • 6 for Unused import
  • 4 for Module is imported with 'import' and 'import from'
  • 2 for 'import *' may pollute namespace

fixed alerts:

  • 21 for Unused import
  • 4 for Module is imported with 'import' and 'import from'
  • 2 for 'import *' may pollute namespace

@blisc
Copy link
Collaborator

blisc commented Jan 23, 2020

Can you add ./test.sh --style-check to Jenkinsfile in place of the pycodestyle?

@stasbel stasbel changed the title [WIP] Black + isort [WIP] Code format checkers Jan 24, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 12 alerts and fixes 12 when merging b371e31 into cdeaf86 - view on LGTM.com

new alerts:

  • 9 for Unused import
  • 2 for 'import *' may pollute namespace
  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 9 for Unused import
  • 2 for 'import *' may pollute namespace
  • 1 for Module is imported with 'import' and 'import from'

@stasbel stasbel requested a review from okuchaiev January 24, 2020 23:20
@stasbel stasbel changed the title [WIP] Code format checkers Code format checkers Jan 24, 2020
okuchaiev
okuchaiev previously approved these changes Jan 24, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2020

This pull request introduces 11 alerts and fixes 11 when merging 816f9c5 into cdeaf86 - view on LGTM.com

new alerts:

  • 9 for Unused import
  • 1 for 'import *' may pollute namespace
  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 9 for Unused import
  • 1 for 'import *' may pollute namespace
  • 1 for Module is imported with 'import' and 'import from'

stasbel and others added 4 commits January 24, 2020 16:12
Signed-off-by: Stanislav Beliaev <[email protected]>
Signed-off-by: Stanislav Beliaev <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2020

This pull request introduces 11 alerts and fixes 11 when merging a698266 into cdeaf86 - view on LGTM.com

new alerts:

  • 9 for Unused import
  • 1 for 'import *' may pollute namespace
  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 9 for Unused import
  • 1 for 'import *' may pollute namespace
  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2020

This pull request introduces 11 alerts and fixes 11 when merging 6234d86 into cdeaf86 - view on LGTM.com

new alerts:

  • 9 for Unused import
  • 1 for 'import *' may pollute namespace
  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 9 for Unused import
  • 1 for 'import *' may pollute namespace
  • 1 for Module is imported with 'import' and 'import from'

Signed-off-by: Stanislav Beliaev <[email protected]>
Signed-off-by: Stanislav Beliaev <[email protected]>
Signed-off-by: Stanislav Beliaev <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2020

This pull request introduces 12 alerts and fixes 10 when merging da0493a into cdeaf86 - view on LGTM.com

new alerts:

  • 9 for Unused import
  • 2 for Implicit string concatenation in a list
  • 1 for 'import *' may pollute namespace

fixed alerts:

  • 9 for Unused import
  • 1 for 'import *' may pollute namespace

@stasbel stasbel requested a review from okuchaiev January 25, 2020 01:05
@stasbel stasbel merged commit 473cdd7 into master Jan 25, 2020
@stasbel stasbel deleted the black branch January 25, 2020 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants