Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squad #270

Merged
merged 22 commits into from
Jan 21, 2020
Merged

Squad #270

merged 22 commits into from
Jan 21, 2020

Conversation

yzhang123
Copy link
Contributor

Adding Code for Question Answering with Squad v1.1 and v2.0,
unit tests, and tutorial.

@yzhang123 yzhang123 requested review from blisc and purn3ndu January 16, 2020 00:03
blisc
blisc requested changes Jan 16, 2020
View reviewed changes
Copy link
Collaborator

@blisc blisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly just style changes. Thank you for adding documentation and tests.

@yzhang123
init commit for squad: set up architecture and training
92120f3 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
added evaluation
d190337 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
fix pep8 for squad.py
7af9008 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
squad is reaching accuracy with bert base uncased
d47499e 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
fixed squad data processing
0a94db7 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
adding squad v2
09a9bba 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
squad v2 working
ecfa737 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
fix pep8
fa15567 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
fix pep8
47b3515 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
adding tests
af0f762 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
added tutorial
fbeb8d6 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
fix syntax error
5de9b40 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
fix syntax error
bdea140 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
adding some doc
530d72d 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
fix pep8
6cb3050 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
integration of PR review
8b7f560 
Signed-off-by: Yang Zhang <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jan 16, 2020

This pull request introduces 7 alerts when merging 8b7f560 into 2bb07bc - view on LGTM.com

new alerts:

  • 5 for Unused import
  • 1 for Signature mismatch in overriding method
  • 1 for Module is imported with 'import' and 'import from'

@yzhang123 yzhang123 requested a review from blisc January 16, 2020 21:48
@lgtm-com
Copy link

lgtm-com bot commented Jan 16, 2020

This pull request introduces 4 alerts when merging f7d8e11 into 2bb07bc - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Signature mismatch in overriding method
  • 1 for Module is imported with 'import' and 'import from'

blisc
blisc requested changes Jan 17, 2020
View reviewed changes
collections/nemo_nlp/nemo_nlp/data/data_layers.py Outdated
@@ -17,20 +17,22 @@
'BertPretrainingPreprocessedDataLayer',
'TranslationDataLayer',
'GlueDataLayerClassification',
'GlueDataLayerRegression']
'GlueDataLayerRegression',
'BertQuestionAnsweringDataLayer']

# from abc import abstractmethod
import sys
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clean up these imports too?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

import sys
import os
import random

import numpy as np
import h5py
import torch
from torch.utils import data as pt_data

Can you make these in alphabetical order (os, random, sys) and (h5py, numpy, torch)?

@yzhang123 yzhang123 removed the request for review from purn3ndu January 17, 2020 18:25
@lgtm-com
Copy link

lgtm-com bot commented Jan 17, 2020

This pull request introduces 4 alerts when merging 3bdbde5 into 2bb07bc - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Signature mismatch in overriding method
  • 1 for Module is imported with 'import' and 'import from'

@yzhang123 yzhang123 requested a review from blisc January 21, 2020 17:48
@yzhang123
delete unused imports
0be37e5 
Signed-off-by: Yang Zhang <[email protected]>
@blisc
Copy link
Collaborator

blisc commented Jan 21, 2020

This pull request introduces 4 alerts when merging 3bdbde5 into 2bb07bc - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Signature mismatch in overriding method
  • 1 for Module is imported with 'import' and 'import from'

Can you remove the unused imports?

@yzhang123
fix syntax error
f7344bc 
Signed-off-by: Yang Zhang <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jan 21, 2020

This pull request introduces 3 alerts when merging f7344bc into bcc94a8 - view on LGTM.com

new alerts:

  • 1 for Signature mismatch in overriding method
  • 1 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@yzhang123
fix LGTM erros
b14b257 
Signed-off-by: Yang Zhang <[email protected]>
@yzhang123 yzhang123 merged commit 35209cb into NVIDIA:master Jan 21, 2020
@blisc blisc mentioned this pull request Jan 21, 2020
Merged
@yzhang123 yzhang123 deleted the squad branch March 12, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blisc blisc blisc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yzhang123 @blisc