Logging update #267
Merged
Logging update #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason <[email protected]>
Signed-off-by: Jason <[email protected]>
Signed-off-by: Jason <[email protected]>
Signed-off-by: Jason <[email protected]>
Signed-off-by: Jason <[email protected]>
Signed-off-by: Jason <[email protected]>
Signed-off-by: Jason <[email protected]>
Signed-off-by: Jason <[email protected]>
Signed-off-by: Jason <[email protected]>
blisc
force-pushed
the
u_logging_update
branch
from
6fa0817 to
9f83e1a
Compare
|
This pull request fixes 4 alerts when merging 9f83e1a into 2bb07bc - view on LGTM.com fixed alerts:
|
collections/nemo_nlp/nemo_nlp/data/datasets/token_classification.py
Outdated
Show resolved
Hide resolved
collections/nemo_nlp/nemo_nlp/data/datasets/token_classification.py
Outdated
Show resolved
Hide resolved
collections/nemo_nlp/nemo_nlp/data/datasets/token_classification.py
Outdated
Show resolved
Hide resolved
collections/nemo_nlp/nemo_nlp/utils/callbacks/sentence_classification.py
Show resolved
Hide resolved
| return get_logger('') | ||
| else: | ||
| return self.action.logger | ||
| warnings.warn("This will be deprecated in future releases. Please use " |
| @@ -805,7 +800,9 @@ def optim_level(self): | |||
|
|
|||
| @property | |||
| def logger(self): | |||
| return self._exp_manager.logger | |||
| warnings.warn("This will be deprecated in future releases. Please use " | |||
There was a problem hiding this comment.
hmmmm, we had that definition already in callbacks.py...
anyway, we will get rid both of them soon, so not really important ;)
tkornuta-nvidia
suggested changes
Jan 16, 2020
There was a problem hiding this comment.
Hey @blisc thanks for taking care of that, great job!
My only comments are that some of those could be changed to debug/warnings. I have indicated all the places where I think it should be done.
@okuchaiev if you think those changes are out of the scope please say so...
Signed-off-by: Jason <[email protected]>
|
This pull request introduces 1 alert and fixes 5 when merging 0200c9e into bcc94a8 - view on LGTM.com new alerts:
fixed alerts:
|
tkornuta-nvidia
approved these changes
Jan 21, 2020
dcurran90
pushed a commit
to dcurran90/NeMo
that referenced
this pull request
Oct 15, 2024
Remove redundancy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated as of PR #311:
Updates the our use of get_logger such that it now defaults to logging.getLogger("nemo_logger") instead of logging.getLogger('')
Updates the our use of get_logger such that it now defaults to logging.getLogger("nemo") instead of logging.getLogger('')Adds the package level variable nemo.logging which can and should be used in place of neuralFactory.logger
Users should use this logger by adding the following line to their code:
from nemo import loggingand then use the logger as per usual, eglogging.info("Message")Default verbosity is set at INFO for process 0
Logger files are still automatically created when neural factory is initialized
The logging formatted was changed to include file and line number that generated the message