Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Megatron in NMT was setting vocab_file to None #2417

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

ericharper
Copy link
Collaborator

Makes vocab_file configurable with Megatron encoders in NeMo NMT.

@ericharper ericharper marked this pull request as draft June 28, 2021 19:54
Signed-off-by: ericharper <[email protected]>
@ericharper ericharper marked this pull request as ready for review June 28, 2021 21:56
@ericharper ericharper requested a review from okuchaiev June 29, 2021 16:06
Copy link
Member

@okuchaiev okuchaiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ericharper ericharper merged commit 0282844 into r1.1.0 Jun 29, 2021
titu1994 added a commit that referenced this pull request Jul 2, 2021
* Update notebook branch and Jenkinsfile for 1.1.0 testing (#2378)

* update branch

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* [BUGFIX] NMT Multi-node was incorrectly computing num_replicas (#2380)

* fix property when not using model parallel

Signed-off-by: ericharper <[email protected]>

* fix property when not using model parallel

Signed-off-by: ericharper <[email protected]>

* add debug statement

Signed-off-by: ericharper <[email protected]>

* add debug statement

Signed-off-by: ericharper <[email protected]>

* instantiate with NLPDDPPlugin with num_nodes from trainer config

Signed-off-by: ericharper <[email protected]>

* Update ASR scripts for tokenizer building and tarred dataset building (#2381)

* Update ASR scripts for tokenizer building and tarred dataset building

Signed-off-by: smajumdar <[email protected]>

* Update container

Signed-off-by: smajumdar <[email protected]>

* Add STT Zh Citrinet 1024 Gamma 0.25 model

Signed-off-by: smajumdar <[email protected]>

* Update notebook (#2391)

Signed-off-by: smajumdar <[email protected]>

* ASR Notebooks fix for 1.1.0 (#2395)

* nb fix for spring clean

Signed-off-by: fayejf <[email protected]>

* remove outdated instruction

Signed-off-by: fayejf <[email protected]>

* Mean normalization (#2397)

* norm embeddings

Signed-off-by: nithinraok <[email protected]>

* move to utils

Signed-off-by: nithinraok <[email protected]>

* Bugfix adaptive spec augment time masking (#2398)

* bugfix adaptive spec augment

Signed-off-by: smajumdar <[email protected]>

* Revert freq mask guard

Signed-off-by: smajumdar <[email protected]>

* Revert freq mask guard

Signed-off-by: smajumdar <[email protected]>

* Remove static time width clamping

Signed-off-by: smajumdar <[email protected]>

* Correct typos and issues with notebooks (#2402)

* Fix Primer notebook

Signed-off-by: smajumdar <[email protected]>

* Typo

Signed-off-by: smajumdar <[email protected]>

* remove accelerator=DDP in tutorial notebooks to avoid errors. (#2403)

Signed-off-by: Hoo Chang Shin <[email protected]>

Co-authored-by: Hoo Chang Shin <[email protected]>

* [BUGFIX] Megatron in NMT was setting vocab_file to None (#2417)

* make vocab_file configurable for megatron in nmt

Signed-off-by: ericharper <[email protected]>

* update docs

Signed-off-by: ericharper <[email protected]>

* update docs

Signed-off-by: ericharper <[email protected]>

* Link updates in docs and notebooks and typo fix (#2416)

* typo fix for notebooks

Signed-off-by: fayejf <[email protected]>

* tiny typo fix in docs

Signed-off-by: fayejf <[email protected]>

* docs branch->stable

Signed-off-by: fayejf <[email protected]>

* more docs branch -> stable

Signed-off-by: fayejf <[email protected]>

* tutorial links branch -> stable

Signed-off-by: fayejf <[email protected]>

* small fix

Signed-off-by: fayejf <[email protected]>

* add renamed 06

Signed-off-by: fayejf <[email protected]>

* more fixes

Signed-off-by: fayejf <[email protected]>

* Update onnx (#2420)

Signed-off-by: smajumdar <[email protected]>

* Correct version of onnxruntime (#2422)

Signed-off-by: smajumdar <[email protected]>

* update deployment instructions (#2430)

Signed-off-by: ericharper <[email protected]>

* Bumping version to 1.1.0

Signed-off-by: Oleksii Kuchaiev <[email protected]>

* update jenksinfile

Signed-off-by: ericharper <[email protected]>

* add upper bounds

Signed-off-by: ericharper <[email protected]>

* update readme

Signed-off-by: ericharper <[email protected]>

* update requirements

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update version

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: fayejf <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
Co-authored-by: khcs <[email protected]>
Co-authored-by: Hoo Chang Shin <[email protected]>
Co-authored-by: Oleksii Kuchaiev <[email protected]>
mousebaiker pushed a commit to mousebaiker/NeMo that referenced this pull request Jul 8, 2021
* Update notebook branch and Jenkinsfile for 1.1.0 testing (NVIDIA#2378)

* update branch

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* [BUGFIX] NMT Multi-node was incorrectly computing num_replicas (NVIDIA#2380)

* fix property when not using model parallel

Signed-off-by: ericharper <[email protected]>

* fix property when not using model parallel

Signed-off-by: ericharper <[email protected]>

* add debug statement

Signed-off-by: ericharper <[email protected]>

* add debug statement

Signed-off-by: ericharper <[email protected]>

* instantiate with NLPDDPPlugin with num_nodes from trainer config

Signed-off-by: ericharper <[email protected]>

* Update ASR scripts for tokenizer building and tarred dataset building (NVIDIA#2381)

* Update ASR scripts for tokenizer building and tarred dataset building

Signed-off-by: smajumdar <[email protected]>

* Update container

Signed-off-by: smajumdar <[email protected]>

* Add STT Zh Citrinet 1024 Gamma 0.25 model

Signed-off-by: smajumdar <[email protected]>

* Update notebook (NVIDIA#2391)

Signed-off-by: smajumdar <[email protected]>

* ASR Notebooks fix for 1.1.0 (NVIDIA#2395)

* nb fix for spring clean

Signed-off-by: fayejf <[email protected]>

* remove outdated instruction

Signed-off-by: fayejf <[email protected]>

* Mean normalization (NVIDIA#2397)

* norm embeddings

Signed-off-by: nithinraok <[email protected]>

* move to utils

Signed-off-by: nithinraok <[email protected]>

* Bugfix adaptive spec augment time masking (NVIDIA#2398)

* bugfix adaptive spec augment

Signed-off-by: smajumdar <[email protected]>

* Revert freq mask guard

Signed-off-by: smajumdar <[email protected]>

* Revert freq mask guard

Signed-off-by: smajumdar <[email protected]>

* Remove static time width clamping

Signed-off-by: smajumdar <[email protected]>

* Correct typos and issues with notebooks (NVIDIA#2402)

* Fix Primer notebook

Signed-off-by: smajumdar <[email protected]>

* Typo

Signed-off-by: smajumdar <[email protected]>

* remove accelerator=DDP in tutorial notebooks to avoid errors. (NVIDIA#2403)

Signed-off-by: Hoo Chang Shin <[email protected]>

Co-authored-by: Hoo Chang Shin <[email protected]>

* [BUGFIX] Megatron in NMT was setting vocab_file to None (NVIDIA#2417)

* make vocab_file configurable for megatron in nmt

Signed-off-by: ericharper <[email protected]>

* update docs

Signed-off-by: ericharper <[email protected]>

* update docs

Signed-off-by: ericharper <[email protected]>

* Link updates in docs and notebooks and typo fix (NVIDIA#2416)

* typo fix for notebooks

Signed-off-by: fayejf <[email protected]>

* tiny typo fix in docs

Signed-off-by: fayejf <[email protected]>

* docs branch->stable

Signed-off-by: fayejf <[email protected]>

* more docs branch -> stable

Signed-off-by: fayejf <[email protected]>

* tutorial links branch -> stable

Signed-off-by: fayejf <[email protected]>

* small fix

Signed-off-by: fayejf <[email protected]>

* add renamed 06

Signed-off-by: fayejf <[email protected]>

* more fixes

Signed-off-by: fayejf <[email protected]>

* Update onnx (NVIDIA#2420)

Signed-off-by: smajumdar <[email protected]>

* Correct version of onnxruntime (NVIDIA#2422)

Signed-off-by: smajumdar <[email protected]>

* update deployment instructions (NVIDIA#2430)

Signed-off-by: ericharper <[email protected]>

* Bumping version to 1.1.0

Signed-off-by: Oleksii Kuchaiev <[email protected]>

* update jenksinfile

Signed-off-by: ericharper <[email protected]>

* add upper bounds

Signed-off-by: ericharper <[email protected]>

* update readme

Signed-off-by: ericharper <[email protected]>

* update requirements

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update version

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: fayejf <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
Co-authored-by: khcs <[email protected]>
Co-authored-by: Hoo Chang Shin <[email protected]>
Co-authored-by: Oleksii Kuchaiev <[email protected]>
pasandi20 pushed a commit to pasandi20/NeMo that referenced this pull request Jul 13, 2021
* Update notebook branch and Jenkinsfile for 1.1.0 testing (NVIDIA#2378)

* update branch

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* [BUGFIX] NMT Multi-node was incorrectly computing num_replicas (NVIDIA#2380)

* fix property when not using model parallel

Signed-off-by: ericharper <[email protected]>

* fix property when not using model parallel

Signed-off-by: ericharper <[email protected]>

* add debug statement

Signed-off-by: ericharper <[email protected]>

* add debug statement

Signed-off-by: ericharper <[email protected]>

* instantiate with NLPDDPPlugin with num_nodes from trainer config

Signed-off-by: ericharper <[email protected]>

* Update ASR scripts for tokenizer building and tarred dataset building (NVIDIA#2381)

* Update ASR scripts for tokenizer building and tarred dataset building

Signed-off-by: smajumdar <[email protected]>

* Update container

Signed-off-by: smajumdar <[email protected]>

* Add STT Zh Citrinet 1024 Gamma 0.25 model

Signed-off-by: smajumdar <[email protected]>

* Update notebook (NVIDIA#2391)

Signed-off-by: smajumdar <[email protected]>

* ASR Notebooks fix for 1.1.0 (NVIDIA#2395)

* nb fix for spring clean

Signed-off-by: fayejf <[email protected]>

* remove outdated instruction

Signed-off-by: fayejf <[email protected]>

* Mean normalization (NVIDIA#2397)

* norm embeddings

Signed-off-by: nithinraok <[email protected]>

* move to utils

Signed-off-by: nithinraok <[email protected]>

* Bugfix adaptive spec augment time masking (NVIDIA#2398)

* bugfix adaptive spec augment

Signed-off-by: smajumdar <[email protected]>

* Revert freq mask guard

Signed-off-by: smajumdar <[email protected]>

* Revert freq mask guard

Signed-off-by: smajumdar <[email protected]>

* Remove static time width clamping

Signed-off-by: smajumdar <[email protected]>

* Correct typos and issues with notebooks (NVIDIA#2402)

* Fix Primer notebook

Signed-off-by: smajumdar <[email protected]>

* Typo

Signed-off-by: smajumdar <[email protected]>

* remove accelerator=DDP in tutorial notebooks to avoid errors. (NVIDIA#2403)

Signed-off-by: Hoo Chang Shin <[email protected]>

Co-authored-by: Hoo Chang Shin <[email protected]>

* [BUGFIX] Megatron in NMT was setting vocab_file to None (NVIDIA#2417)

* make vocab_file configurable for megatron in nmt

Signed-off-by: ericharper <[email protected]>

* update docs

Signed-off-by: ericharper <[email protected]>

* update docs

Signed-off-by: ericharper <[email protected]>

* Link updates in docs and notebooks and typo fix (NVIDIA#2416)

* typo fix for notebooks

Signed-off-by: fayejf <[email protected]>

* tiny typo fix in docs

Signed-off-by: fayejf <[email protected]>

* docs branch->stable

Signed-off-by: fayejf <[email protected]>

* more docs branch -> stable

Signed-off-by: fayejf <[email protected]>

* tutorial links branch -> stable

Signed-off-by: fayejf <[email protected]>

* small fix

Signed-off-by: fayejf <[email protected]>

* add renamed 06

Signed-off-by: fayejf <[email protected]>

* more fixes

Signed-off-by: fayejf <[email protected]>

* Update onnx (NVIDIA#2420)

Signed-off-by: smajumdar <[email protected]>

* Correct version of onnxruntime (NVIDIA#2422)

Signed-off-by: smajumdar <[email protected]>

* update deployment instructions (NVIDIA#2430)

Signed-off-by: ericharper <[email protected]>

* Bumping version to 1.1.0

Signed-off-by: Oleksii Kuchaiev <[email protected]>

* update jenksinfile

Signed-off-by: ericharper <[email protected]>

* add upper bounds

Signed-off-by: ericharper <[email protected]>

* update readme

Signed-off-by: ericharper <[email protected]>

* update requirements

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update version

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: fayejf <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
Co-authored-by: khcs <[email protected]>
Co-authored-by: Hoo Chang Shin <[email protected]>
Co-authored-by: Oleksii Kuchaiev <[email protected]>
Signed-off-by: Ghasem Pasandi <[email protected]>
fayejf added a commit that referenced this pull request Jul 16, 2021
* Update notebook branch and Jenkinsfile for 1.1.0 testing (#2378)

* update branch

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* [BUGFIX] NMT Multi-node was incorrectly computing num_replicas (#2380)

* fix property when not using model parallel

Signed-off-by: ericharper <[email protected]>

* fix property when not using model parallel

Signed-off-by: ericharper <[email protected]>

* add debug statement

Signed-off-by: ericharper <[email protected]>

* add debug statement

Signed-off-by: ericharper <[email protected]>

* instantiate with NLPDDPPlugin with num_nodes from trainer config

Signed-off-by: ericharper <[email protected]>

* Update ASR scripts for tokenizer building and tarred dataset building (#2381)

* Update ASR scripts for tokenizer building and tarred dataset building

Signed-off-by: smajumdar <[email protected]>

* Update container

Signed-off-by: smajumdar <[email protected]>

* Add STT Zh Citrinet 1024 Gamma 0.25 model

Signed-off-by: smajumdar <[email protected]>

* Update notebook (#2391)

Signed-off-by: smajumdar <[email protected]>

* ASR Notebooks fix for 1.1.0 (#2395)

* nb fix for spring clean

Signed-off-by: fayejf <[email protected]>

* remove outdated instruction

Signed-off-by: fayejf <[email protected]>

* Mean normalization (#2397)

* norm embeddings

Signed-off-by: nithinraok <[email protected]>

* move to utils

Signed-off-by: nithinraok <[email protected]>

* Bugfix adaptive spec augment time masking (#2398)

* bugfix adaptive spec augment

Signed-off-by: smajumdar <[email protected]>

* Revert freq mask guard

Signed-off-by: smajumdar <[email protected]>

* Revert freq mask guard

Signed-off-by: smajumdar <[email protected]>

* Remove static time width clamping

Signed-off-by: smajumdar <[email protected]>

* Correct typos and issues with notebooks (#2402)

* Fix Primer notebook

Signed-off-by: smajumdar <[email protected]>

* Typo

Signed-off-by: smajumdar <[email protected]>

* remove accelerator=DDP in tutorial notebooks to avoid errors. (#2403)

Signed-off-by: Hoo Chang Shin <[email protected]>

Co-authored-by: Hoo Chang Shin <[email protected]>

* [BUGFIX] Megatron in NMT was setting vocab_file to None (#2417)

* make vocab_file configurable for megatron in nmt

Signed-off-by: ericharper <[email protected]>

* update docs

Signed-off-by: ericharper <[email protected]>

* update docs

Signed-off-by: ericharper <[email protected]>

* Link updates in docs and notebooks and typo fix (#2416)

* typo fix for notebooks

Signed-off-by: fayejf <[email protected]>

* tiny typo fix in docs

Signed-off-by: fayejf <[email protected]>

* docs branch->stable

Signed-off-by: fayejf <[email protected]>

* more docs branch -> stable

Signed-off-by: fayejf <[email protected]>

* tutorial links branch -> stable

Signed-off-by: fayejf <[email protected]>

* small fix

Signed-off-by: fayejf <[email protected]>

* add renamed 06

Signed-off-by: fayejf <[email protected]>

* more fixes

Signed-off-by: fayejf <[email protected]>

* Update onnx (#2420)

Signed-off-by: smajumdar <[email protected]>

* Correct version of onnxruntime (#2422)

Signed-off-by: smajumdar <[email protected]>

* update deployment instructions (#2430)

Signed-off-by: ericharper <[email protected]>

* Bumping version to 1.1.0

Signed-off-by: Oleksii Kuchaiev <[email protected]>

* update jenksinfile

Signed-off-by: ericharper <[email protected]>

* add upper bounds

Signed-off-by: ericharper <[email protected]>

* update readme

Signed-off-by: ericharper <[email protected]>

* update requirements

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update version

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: fayejf <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
Co-authored-by: khcs <[email protected]>
Co-authored-by: Hoo Chang Shin <[email protected]>
Co-authored-by: Oleksii Kuchaiev <[email protected]>
titu1994 added a commit to titu1994/NeMo that referenced this pull request Jul 20, 2021
* Update notebook branch and Jenkinsfile for 1.1.0 testing (NVIDIA#2378)

* update branch

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* [BUGFIX] NMT Multi-node was incorrectly computing num_replicas (NVIDIA#2380)

* fix property when not using model parallel

Signed-off-by: ericharper <[email protected]>

* fix property when not using model parallel

Signed-off-by: ericharper <[email protected]>

* add debug statement

Signed-off-by: ericharper <[email protected]>

* add debug statement

Signed-off-by: ericharper <[email protected]>

* instantiate with NLPDDPPlugin with num_nodes from trainer config

Signed-off-by: ericharper <[email protected]>

* Update ASR scripts for tokenizer building and tarred dataset building (NVIDIA#2381)

* Update ASR scripts for tokenizer building and tarred dataset building

Signed-off-by: smajumdar <[email protected]>

* Update container

Signed-off-by: smajumdar <[email protected]>

* Add STT Zh Citrinet 1024 Gamma 0.25 model

Signed-off-by: smajumdar <[email protected]>

* Update notebook (NVIDIA#2391)

Signed-off-by: smajumdar <[email protected]>

* ASR Notebooks fix for 1.1.0 (NVIDIA#2395)

* nb fix for spring clean

Signed-off-by: fayejf <[email protected]>

* remove outdated instruction

Signed-off-by: fayejf <[email protected]>

* Mean normalization (NVIDIA#2397)

* norm embeddings

Signed-off-by: nithinraok <[email protected]>

* move to utils

Signed-off-by: nithinraok <[email protected]>

* Bugfix adaptive spec augment time masking (NVIDIA#2398)

* bugfix adaptive spec augment

Signed-off-by: smajumdar <[email protected]>

* Revert freq mask guard

Signed-off-by: smajumdar <[email protected]>

* Revert freq mask guard

Signed-off-by: smajumdar <[email protected]>

* Remove static time width clamping

Signed-off-by: smajumdar <[email protected]>

* Correct typos and issues with notebooks (NVIDIA#2402)

* Fix Primer notebook

Signed-off-by: smajumdar <[email protected]>

* Typo

Signed-off-by: smajumdar <[email protected]>

* remove accelerator=DDP in tutorial notebooks to avoid errors. (NVIDIA#2403)

Signed-off-by: Hoo Chang Shin <[email protected]>

Co-authored-by: Hoo Chang Shin <[email protected]>

* [BUGFIX] Megatron in NMT was setting vocab_file to None (NVIDIA#2417)

* make vocab_file configurable for megatron in nmt

Signed-off-by: ericharper <[email protected]>

* update docs

Signed-off-by: ericharper <[email protected]>

* update docs

Signed-off-by: ericharper <[email protected]>

* Link updates in docs and notebooks and typo fix (NVIDIA#2416)

* typo fix for notebooks

Signed-off-by: fayejf <[email protected]>

* tiny typo fix in docs

Signed-off-by: fayejf <[email protected]>

* docs branch->stable

Signed-off-by: fayejf <[email protected]>

* more docs branch -> stable

Signed-off-by: fayejf <[email protected]>

* tutorial links branch -> stable

Signed-off-by: fayejf <[email protected]>

* small fix

Signed-off-by: fayejf <[email protected]>

* add renamed 06

Signed-off-by: fayejf <[email protected]>

* more fixes

Signed-off-by: fayejf <[email protected]>

* Update onnx (NVIDIA#2420)

Signed-off-by: smajumdar <[email protected]>

* Correct version of onnxruntime (NVIDIA#2422)

Signed-off-by: smajumdar <[email protected]>

* update deployment instructions (NVIDIA#2430)

Signed-off-by: ericharper <[email protected]>

* Bumping version to 1.1.0

Signed-off-by: Oleksii Kuchaiev <[email protected]>

* update jenksinfile

Signed-off-by: ericharper <[email protected]>

* add upper bounds

Signed-off-by: ericharper <[email protected]>

* update readme

Signed-off-by: ericharper <[email protected]>

* update requirements

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update version

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: fayejf <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
Co-authored-by: khcs <[email protected]>
Co-authored-by: Hoo Chang Shin <[email protected]>
Co-authored-by: Oleksii Kuchaiev <[email protected]>
paarthneekhara pushed a commit to paarthneekhara/NeMo that referenced this pull request Sep 17, 2021
* Update notebook branch and Jenkinsfile for 1.1.0 testing (NVIDIA#2378)

* update branch

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* [BUGFIX] NMT Multi-node was incorrectly computing num_replicas (NVIDIA#2380)

* fix property when not using model parallel

Signed-off-by: ericharper <[email protected]>

* fix property when not using model parallel

Signed-off-by: ericharper <[email protected]>

* add debug statement

Signed-off-by: ericharper <[email protected]>

* add debug statement

Signed-off-by: ericharper <[email protected]>

* instantiate with NLPDDPPlugin with num_nodes from trainer config

Signed-off-by: ericharper <[email protected]>

* Update ASR scripts for tokenizer building and tarred dataset building (NVIDIA#2381)

* Update ASR scripts for tokenizer building and tarred dataset building

Signed-off-by: smajumdar <[email protected]>

* Update container

Signed-off-by: smajumdar <[email protected]>

* Add STT Zh Citrinet 1024 Gamma 0.25 model

Signed-off-by: smajumdar <[email protected]>

* Update notebook (NVIDIA#2391)

Signed-off-by: smajumdar <[email protected]>

* ASR Notebooks fix for 1.1.0 (NVIDIA#2395)

* nb fix for spring clean

Signed-off-by: fayejf <[email protected]>

* remove outdated instruction

Signed-off-by: fayejf <[email protected]>

* Mean normalization (NVIDIA#2397)

* norm embeddings

Signed-off-by: nithinraok <[email protected]>

* move to utils

Signed-off-by: nithinraok <[email protected]>

* Bugfix adaptive spec augment time masking (NVIDIA#2398)

* bugfix adaptive spec augment

Signed-off-by: smajumdar <[email protected]>

* Revert freq mask guard

Signed-off-by: smajumdar <[email protected]>

* Revert freq mask guard

Signed-off-by: smajumdar <[email protected]>

* Remove static time width clamping

Signed-off-by: smajumdar <[email protected]>

* Correct typos and issues with notebooks (NVIDIA#2402)

* Fix Primer notebook

Signed-off-by: smajumdar <[email protected]>

* Typo

Signed-off-by: smajumdar <[email protected]>

* remove accelerator=DDP in tutorial notebooks to avoid errors. (NVIDIA#2403)

Signed-off-by: Hoo Chang Shin <[email protected]>

Co-authored-by: Hoo Chang Shin <[email protected]>

* [BUGFIX] Megatron in NMT was setting vocab_file to None (NVIDIA#2417)

* make vocab_file configurable for megatron in nmt

Signed-off-by: ericharper <[email protected]>

* update docs

Signed-off-by: ericharper <[email protected]>

* update docs

Signed-off-by: ericharper <[email protected]>

* Link updates in docs and notebooks and typo fix (NVIDIA#2416)

* typo fix for notebooks

Signed-off-by: fayejf <[email protected]>

* tiny typo fix in docs

Signed-off-by: fayejf <[email protected]>

* docs branch->stable

Signed-off-by: fayejf <[email protected]>

* more docs branch -> stable

Signed-off-by: fayejf <[email protected]>

* tutorial links branch -> stable

Signed-off-by: fayejf <[email protected]>

* small fix

Signed-off-by: fayejf <[email protected]>

* add renamed 06

Signed-off-by: fayejf <[email protected]>

* more fixes

Signed-off-by: fayejf <[email protected]>

* Update onnx (NVIDIA#2420)

Signed-off-by: smajumdar <[email protected]>

* Correct version of onnxruntime (NVIDIA#2422)

Signed-off-by: smajumdar <[email protected]>

* update deployment instructions (NVIDIA#2430)

Signed-off-by: ericharper <[email protected]>

* Bumping version to 1.1.0

Signed-off-by: Oleksii Kuchaiev <[email protected]>

* update jenksinfile

Signed-off-by: ericharper <[email protected]>

* add upper bounds

Signed-off-by: ericharper <[email protected]>

* update readme

Signed-off-by: ericharper <[email protected]>

* update requirements

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update version

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: fayejf <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
Co-authored-by: khcs <[email protected]>
Co-authored-by: Hoo Chang Shin <[email protected]>
Co-authored-by: Oleksii Kuchaiev <[email protected]>
Signed-off-by: Paarth Neekhara <[email protected]>
@blisc blisc deleted the nmt_fix_megatron_vocab branch January 11, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants