Prepare RNNT to switch to Numba loss for compatibility #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titu1994
force-pushed
the
add_rnnt_loss_support
branch
from
c689da2 to
e19d920
Compare
VahidooX
requested changes
Apr 1, 2021
titu1994
force-pushed
the
add_rnnt_loss_support
branch
from
16fb51d to
0e53390
Compare
|
This pull request fixes 2 alerts when merging 4848e4c into 094b58b - view on LGTM.com fixed alerts:
|
|
This pull request fixes 2 alerts when merging 0d2c041 into 094b58b - view on LGTM.com fixed alerts:
|
VahidooX
approved these changes
Apr 2, 2021
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
titu1994
force-pushed
the
add_rnnt_loss_support
branch
from
0d2c041 to
b281d1f
Compare
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
|
This pull request fixes 2 alerts when merging b281d1f into 682e90d - view on LGTM.com fixed alerts:
|
vadam5
pushed a commit
to vadam5/NeMo
that referenced
this pull request
Apr 9, 2021
* Prepare RNNT to switch to Numba loss for compatibility Signed-off-by: smajumdar <[email protected]> * Update tests for RNNT Signed-off-by: smajumdar <[email protected]> * Address comments Signed-off-by: smajumdar <[email protected]> * Address comments Signed-off-by: smajumdar <[email protected]> * Fix wrong resolution of gradient calculation Signed-off-by: smajumdar <[email protected]> * Fix wrong resolution of gradient calculation Signed-off-by: smajumdar <[email protected]> * Drop WarpRNNT requirement Signed-off-by: smajumdar <[email protected]> Signed-off-by: Virginia Adams <[email protected]>
vadam5
pushed a commit
to vadam5/NeMo
that referenced
this pull request
Apr 12, 2021
* Prepare RNNT to switch to Numba loss for compatibility Signed-off-by: smajumdar <[email protected]> * Update tests for RNNT Signed-off-by: smajumdar <[email protected]> * Address comments Signed-off-by: smajumdar <[email protected]> * Address comments Signed-off-by: smajumdar <[email protected]> * Fix wrong resolution of gradient calculation Signed-off-by: smajumdar <[email protected]> * Fix wrong resolution of gradient calculation Signed-off-by: smajumdar <[email protected]> * Drop WarpRNNT requirement Signed-off-by: smajumdar <[email protected]> Signed-off-by: Virginia Adams <[email protected]>
michalivne
pushed a commit
to michalivne/NeMo
that referenced
this pull request
Jun 23, 2021
* Prepare RNNT to switch to Numba loss for compatibility Signed-off-by: smajumdar <[email protected]> * Update tests for RNNT Signed-off-by: smajumdar <[email protected]> * Address comments Signed-off-by: smajumdar <[email protected]> * Address comments Signed-off-by: smajumdar <[email protected]> * Fix wrong resolution of gradient calculation Signed-off-by: smajumdar <[email protected]> * Fix wrong resolution of gradient calculation Signed-off-by: smajumdar <[email protected]> * Drop WarpRNNT requirement Signed-off-by: smajumdar <[email protected]> Signed-off-by: Micha Livne <[email protected]>
mousebaiker
pushed a commit
to mousebaiker/NeMo
that referenced
this pull request
Jul 8, 2021
* Prepare RNNT to switch to Numba loss for compatibility Signed-off-by: smajumdar <[email protected]> * Update tests for RNNT Signed-off-by: smajumdar <[email protected]> * Address comments Signed-off-by: smajumdar <[email protected]> * Address comments Signed-off-by: smajumdar <[email protected]> * Fix wrong resolution of gradient calculation Signed-off-by: smajumdar <[email protected]> * Fix wrong resolution of gradient calculation Signed-off-by: smajumdar <[email protected]> * Drop WarpRNNT requirement Signed-off-by: smajumdar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Signed-off-by: smajumdar [email protected]