Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced classification model with EncDecSpeakerLabelModel #11887

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ssofja
Copy link
Collaborator

@Ssofja Ssofja commented Jan 17, 2025

What does this PR do ?

This PR Replaced ASR classification model with EncDecSpeakerLabelModel without a need to change a lot of code parts
Collection: ASR

Changelog

  • Add specific line by line info of high level changes in this PR.

PR Type:

  • Refactoring

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@Ssofja Ssofja requested a review from nithinraok January 17, 2025 22:16
@github-actions github-actions bot added the ASR label Jan 17, 2025
@Ssofja Ssofja force-pushed the classification_models_replacement branch from fb47acc to 2ca5a9e Compare January 17, 2025 22:38
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.asr.models.classification_models
nemo/collections/asr/models/classification_models.py:381:0: C0301: Line too long (122/119) (line-too-long)
nemo/collections/asr/models/classification_models.py:516:0: C0301: Line too long (120/119) (line-too-long)
nemo/collections/asr/models/classification_models.py:726:0: C0301: Line too long (163/119) (line-too-long)
nemo/collections/asr/models/classification_models.py:727:0: C0301: Line too long (165/119) (line-too-long)
nemo/collections/asr/models/classification_models.py:938:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/classification_models.py:939:0: C0301: Line too long (142/119) (line-too-long)
nemo/collections/asr/models/classification_models.py:940:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/classification_models.py:941:0: C0301: Line too long (151/119) (line-too-long)
nemo/collections/asr/models/classification_models.py:942:0: C0301: Line too long (149/119) (line-too-long)
nemo/collections/asr/models/classification_models.py:1034:0: C0301: Line too long (120/119) (line-too-long)
nemo/collections/asr/models/classification_models.py:49:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/asr/models/classification_models.py:57:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/asr/models/classification_models.py:161:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/classification_models.py:488:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/asr/models/classification_models.py:613:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/classification_models.py:631:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/classification_models.py:640:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/classification_models.py:708:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/asr/models/classification_models.py:818:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/classification_models.py:43:0: W0611: Unused deprecated imported from nemo.utils.decorators (unused-import)

-----------------------------------
Your code has been rated at 9.61/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant