Pipeline-parallel support for Knowledge Distillation (NeMo 2) #11766
+1,027
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
AAnoosheh
force-pushed
the
aanoosheh/pp-distillation-nemo2
branch
from
0ce6e7d to
b748ae8
Compare
AAnoosheh
requested review from
ericharper,
ntajbakhsh,
dimapihtar,
JRD971000,
yashaswikarnati and
sharathts
AAnoosheh
force-pushed
the
aanoosheh/pp-distillation-nemo2
branch
from
1538557 to
19e4a3a
Compare
AAnoosheh
force-pushed
the
aanoosheh/pp-distillation-nemo2
branch
2 times, most recently
from
896e802 to
ae95fa8
Compare
AAnoosheh
force-pushed
the
aanoosheh/pp-distillation-nemo2
branch
from
7d980cb to
2bd6e40
Compare
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
AAnoosheh
force-pushed
the
aanoosheh/pp-distillation-nemo2
branch
from
3539768 to
7f1e572
Compare
Signed-off-by: Asha Anoosheh <[email protected]>
Signed-off-by: Asha Anoosheh <[email protected]>
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
ko3n1g
reviewed
Jan 29, 2025
yashaswikarnati
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Enable Pipeline-Parallelism in conjunction with student-teacher distillation in NeMo 2
Collection: [LLM]
Changelog
nemo/collections/llm/distillationMegatronParallelforward pass to run teacher in addition to studentUsage
python scripts/llm/gpt_distillation.py \ --name experiment_name \ --teacher_path /path/to/nemo2/teacher \ --student_path /path/to/nemo2/student \ --tp_size 4 \ --cp_size 1 \ --pp_size 2 \ --devices 8 \ --log_dir /tmp/nemo2_llama_distill \ --max_steps 100 \ --gbs 64 \ --mbs 4 \ --data_paths weight1 /path/to/data/1 weight2 /path/to/data/2 \ --index_mapping_dir /path/to/data/cache/ \ --seq_length 8192 \ --warmup_steps 5 \ --val_check_interval 50 \ --log_interval 5GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information