r2.1.0 ptl fix #11694
Merged
r2.1.0 ptl fix #11694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Garay <[email protected]>
jstjohn
reviewed
Dec 20, 2024
| @@ -1,7 +1,7 @@ | |||
| cloudpickle | |||
| fiddle | |||
| hydra-core>1.3,<=1.3.2 | |||
| lightning>2.2.1 | |||
| lightning>2.2.1,<=2.4.0 | |||
There was a problem hiding this comment.
Are you addressing the progress printer issue with 2.5? You can fix that directly by calling on_train_epoch_start from inside of a new on_fit_start in the progressprinter class.
There was a problem hiding this comment.
Eg you could add:
@override
def on_fit_start(self, trainer: Trainer, pl_module: LightningModule) -> None:
self.on_train_epoch_start(trainer, pl_module)Right before https://github.com/NVIDIA/NeMo/blob/main/nemo/lightning/pytorch/callbacks/progress_printer.py#L114-L120
There was a problem hiding this comment.
that got 2.5 working for me with job resumption without the AttributeError: 'ProgressPrinter' object has no attribute 'total' error.
There was a problem hiding this comment.
Virtually all tests are failing. Thats why . Needs workaround before 2.5 upgrade
|
This change made tests pass again, so merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r2.1.0 ptl fix