Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Rename multimodal data module - EnergonMultiModalDataModule (11654) into r2.1.0 #11685

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Dec 20, 2024

beep boop [🤖]: Hi @yashaswikarnati 👋,

we've cherry picked #11654 into  for you! 🚀

Please review and approve this cherry pick by your convenience!

* rename multimodal data module

* Apply isort and black reformatting

Signed-off-by: yashaswikarnati <[email protected]>

* fix long lengths

* fix lint issues

* fix long lint issues

---------

Signed-off-by: yashaswikarnati <[email protected]>
Co-authored-by: yashaswikarnati <[email protected]>
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

2 similar comments
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

Copy link
Contributor

beep boop 🤖: 🚨 The following files must be fixed before merge!


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

1 similar comment
Copy link
Contributor

beep boop 🤖: 🚨 The following files must be fixed before merge!


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

@pablo-garay pablo-garay merged commit 49761f5 into r2.1.0 Dec 20, 2024
169 of 173 checks passed
@pablo-garay pablo-garay deleted the cherry-pick-11654-r2.1.0 branch December 20, 2024 13:18
Copy link
Contributor

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants