Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix docstring for VAD #11659

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Add fix docstring for VAD #11659

merged 1 commit into from
Dec 19, 2024

Conversation

titu1994
Copy link
Collaborator

What does this PR do ?

Add a statement to use VAD only in colab environment

Collection: [ASR]

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

@github-actions github-actions bot added the ASR label Dec 19, 2024
@titu1994 titu1994 merged commit c46ba6f into NVIDIA:main Dec 19, 2024
146 of 148 checks passed
@titu1994 titu1994 deleted the fix_vad branch December 19, 2024 02:53
ko3n1g pushed a commit that referenced this pull request Dec 19, 2024
titu1994 added a commit that referenced this pull request Dec 19, 2024
Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
jihyeonRyu pushed a commit to jihyeonRyu/NeMo that referenced this pull request Dec 20, 2024
jihyeonRyu pushed a commit to jihyeonRyu/NeMo that referenced this pull request Dec 20, 2024
BoxiangW pushed a commit that referenced this pull request Dec 20, 2024
BoxiangW pushed a commit that referenced this pull request Dec 23, 2024
abhinavg4 pushed a commit that referenced this pull request Jan 30, 2025
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Abhinav Garg <[email protected]>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Youngeun Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant